src,test: disable per_context.js shim

The `Intl` usage in the the shim is causing issues in ChakraCore on Linux and Mac. Since we don't necessarily need the `Atomics.notify` shim code either the simplest solution is to remove the shim completely for ChakraCore. Refs: nodejs#565 Refs: nodejs#567 PR-URL: nodejs#566 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung · Jul 10, 2018 · f5d29d5 · f5d29d5
1 parent 3b49f28
commit f5d29d5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -4204,6 +4204,7 @@ Local<Context> NewContext(Isolate* isolate,
   context->SetEmbedderData(
       ContextEmbedderIndex::kAllowWasmCodeGeneration, True(isolate));
 
+#ifndef NODE_ENGINE_CHAKRACORE
   {
     // Run lib/internal/per_context.js
     Context::Scope context_scope(context);
@@ -4214,6 +4215,7 @@ Local<Context> NewContext(Isolate* isolate,
         &per_context_src).ToLocalChecked();
     s->Run(context).ToLocalChecked();
   }
+#endif
 
   return context;
 }

diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -248,6 +248,10 @@ test-worker-workerdata-sharedarraybuffer : SKIP
 # See bug https://github.com/nodejs/node-chakracore/issues/560
 test-vm-createcacheddata : SKIP
 
+# Removed the wake->notify shim code
+# Issue: https://github.com/nodejs/node-chakracore/issues/565
+test-atomics-notify : SKIP
+
 [$jsEngine==chakracore && $arch==x64]
 # These tests are failing for Node-Chakracore and should eventually be fixed
 test-buffer-includes : SKIP