refactored tests

kgmcquate · Jan 2, 2024 · 110fd99 · 110fd99
1 parent 8dacdf5
commit 110fd99
Show file tree

Hide file tree

Showing 10 changed files with 27 additions and 15 deletions.
diff --git a/.github/workflows/dbt_test.yml b/.github/workflows/dbt_test.yml
@@ -35,10 +35,10 @@ jobs:
     - name: load test data
       run: dbt seed --target duckdb
 
-    - name: Generate tests
+    - name: Create seed tests
       run: dbt compile -q --inline "{{ testgen.get_test_suggestions(ref('users'), resource_type='seeds') }}" > seeds/users_test_suggestions.yml
 
-    - name: Generate tests
+    - name: Create seed tests
       run: "dbt compile -q --inline \"{{ testgen.get_test_suggestions(ref('colnames_with_spaces'), resource_type='seeds', column_config={'quote': true}) }}\"  > seeds/colnames_with_spaces_test_suggestions.yml"
 
     - name: dbt test

diff --git a/...ation_tests/tests/generate_accepted_values_tests/accepted_values_colnames_with_spaces.sql b/...ation_tests/tests/generate_accepted_values_tests/accepted_values_colnames_with_spaces.sql
@@ -1,10 +1,10 @@
 
 
-{% set actual_yaml = toyaml(fromjson(tojson(
+{% set actual_yaml = testgen.to_yaml(
         testgen.get_accepted_values_test_suggestions(
             ref('colnames_with_spaces')
         )
-    )))
+    )
 %}
 
 {% set expected_yaml %}

diff --git a/integration_tests/tests/generate_accepted_values_tests/accepted_values_users.sql b/integration_tests/tests/generate_accepted_values_tests/accepted_values_users.sql
@@ -1,10 +1,10 @@
 
 
-{% set actual_yaml = toyaml(fromjson(tojson(
+{% set actual_yaml = testgen.to_yaml(
         testgen.get_accepted_values_test_suggestions(
             ref('users')
         )
-    )))
+    )
 %}
 
 {% set expected_yaml %}

diff --git a/integration_tests/tests/generate_range_tests/range_colnames_with_spaces.sql b/integration_tests/tests/generate_range_tests/range_colnames_with_spaces.sql
@@ -1,10 +1,10 @@
 
 
-{% set actual_yaml = toyaml(fromjson(tojson(
+{% set actual_yaml = testgen.to_yaml(
         testgen.get_range_test_suggestions(
             ref('colnames_with_spaces')
         )
-    )))
+    )
 %}
 
 {% set expected_yaml %}

diff --git a/integration_tests/tests/generate_range_tests/range_users.sql b/integration_tests/tests/generate_range_tests/range_users.sql
@@ -1,10 +1,10 @@
 
 
-{% set actual_yaml = toyaml(fromjson(tojson(
+{% set actual_yaml = testgen.to_yaml(
         testgen.get_range_test_suggestions(
             ref('users')
         )
-    )))
+    )
 %}
 
 {% set expected_yaml %}

diff --git a/integration_tests/tests/generate_uniqueness_tests/uniqueness_colnames_with_spaces.sql b/integration_tests/tests/generate_uniqueness_tests/uniqueness_colnames_with_spaces.sql
@@ -1,11 +1,12 @@
 
 
-{% set actual_yaml = toyaml(fromjson(tojson(
+{% set actual_yaml = testgen.to_yaml(
         testgen.get_uniqueness_test_suggestions(
             ref('colnames_with_spaces'),
-            composite_key_length = 1
+            composite_key_length = 1,
+            column_config={'quote': true}
         )
-    )))
+    )
 %}
 
 {% set expected_yaml %}
@@ -17,16 +18,19 @@ models:
     tests:
     - unique
     - not_null
+    quote: true
   - name: Age (Years)
     description: Uniqueness test generated by dbt-testgen
     tests:
     - unique
     - not_null
+    quote: true
   - name: Current City
     description: Uniqueness test generated by dbt-testgen
     tests:
     - unique
     - not_null
+    quote: true
 {% endset %}
 
 {{ assert_equal (actual_yaml | trim, expected_yaml | trim) }}
diff --git a/integration_tests/tests/generate_uniqueness_tests/uniqueness_users.sql b/integration_tests/tests/generate_uniqueness_tests/uniqueness_users.sql
@@ -1,11 +1,11 @@
 
 
-{% set actual_yaml = toyaml(fromjson(tojson(
+{% set actual_yaml = testgen.to_yaml(
         testgen.get_uniqueness_test_suggestions(
             ref('users'),
             composite_key_length = 1
         )
-    )))
+    )
 %}
 
 {% set expected_yaml %}

diff --git a/integration_tests/tests/merge_dbt_configs/merge_dbt_configs_1.sql b/integration_tests/tests/merge_dbt_configs/merge_dbt_configs_1.sql
@@ -44,6 +44,7 @@ models:
 - name: users
   columns:
   - name: user_id
+    description: Uniqueness test generated by dbt-testgen
     tests:
     - unique:
         tags:
@@ -52,6 +53,7 @@ models:
         tags:
         - uniqueness
   - name: email
+    description: Uniqueness test generated by dbt-testgen
     tests:
     - unique:
         tags:

diff --git a/integration_tests/tests/merge_dbt_configs/merge_dbt_configs_2.sql b/integration_tests/tests/merge_dbt_configs/merge_dbt_configs_2.sql
@@ -42,6 +42,7 @@ models:
 - name: users
   columns:
   - name: user_id
+    description: Uniqueness test generated by dbt-testgen
     tests:
     - unique:
         tags:

diff --git a/integration_tests/tests/test_test_selection/test_selection_users.sql b/integration_tests/tests/test_test_selection/test_selection_users.sql
@@ -13,27 +13,32 @@ models:
 - name: users
   columns:
   - name: user_id
+    description: Numeric range test generated by dbt-testgen
     tests:
     - unique
     - not_null
     - dbt_utils.accepted_range:
         min_value: 1
         max_value: 30
   - name: username
+    description: Uniqueness test generated by dbt-testgen
     tests:
     - unique
     - not_null
   - name: email
+    description: Uniqueness test generated by dbt-testgen
     tests:
     - unique
     - not_null
   - name: user_status
+    description: Accepted values test generated by dbt-testgen
     tests:
     - accepted_values:
         values:
         - active
         - inactive
   - name: age
+    description: Numeric range test generated by dbt-testgen
     tests:
     - dbt_utils.accepted_range:
         min_value: 22