Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isFemale parameter #75

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

WatheqAlshowaiter
Copy link
Contributor

Add $isFemalte parameter for arPlural() method to return the correct male/female word if you know it.

e.g: خطأ is detected as 'female' which is wrong. if you have 1 number خطأ واحدة. With my pull request I can add isFemale = false to have result خطأ واحد.

in Addition to the code modification, I have added

  1. the example.
  2. the corresponding test.
  3. the docs modification.

@khaled-alshamaa
Copy link
Owner

Thank you @WatheqAlshowaiter for catching that buggy use case and fixing it 👍

@khaled-alshamaa khaled-alshamaa merged commit 55c5ed4 into khaled-alshamaa:master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants