Add a method to delete user #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ecton
requested changes
Mar 2, 2022
| @@ -326,6 +332,8 @@ pub enum ServerResponse { | |||
| /// The id of the user created. | |||
| id: u64, | |||
| }, | |||
| /// A user was deleted. | |||
| UserDeleted, | |||
There was a problem hiding this comment.
Since there is no information being returned, let's remove this variant and have the networking client use Response::Ok instead.
crates/bonsaidb-local/src/storage.rs
Outdated
Comment on lines
735
to
741
| // // Retrieve a user to delete | ||
| // let doc = self | ||
| // .admin() | ||
| // .await | ||
| // .collection::<User>() | ||
| // .get(primary_key) | ||
| // .await?; |
| #[cfg_attr(feature = "actionable-traits", actionable(protection = "simple"))] | ||
| DeleteUser { | ||
| /// The unique primary key of the user to be deleted. | ||
| primary_key: NamedReference<'static, u64>, |
There was a problem hiding this comment.
To match the other networking requests, let's rename this to user. A NamedReference can be either a unique name (in this case, the username) or the primary key (in this case, u64). Since it can contain data that isn't the primary_key, that's why I used user instead on the other request types.
ecton
approved these changes
Mar 2, 2022
ecton
requested changes
Mar 2, 2022
crates/bonsaidb-local/src/storage.rs
Outdated
| let doc = User::load(user, &admin) | ||
| .await? | ||
| .ok_or(bonsaidb_core::Error::UserNotFound)?; | ||
| self.admin().await.collection::<User>().delete(&doc).await?; |
There was a problem hiding this comment.
Suggested change
| self.admin().await.collection::<User>().delete(&doc).await?; | |
| doc.delete(&admin).await?; |
ecton
approved these changes
Mar 2, 2022
ecton
added a commit
that referenced
this pull request
Mar 2, 2022
Also added more notes on what to run before pushing changes. I need to get CI hooked up to pull requests. Refs #215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #83.