Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Hover Color Matching in Navbar and Enhanced Navbar on Home Page #1316

Merged
merged 11 commits into from
Jul 23, 2024

Conversation

jency1
Copy link
Contributor

@jency1 jency1 commented Jul 8, 2024

Related Issue

#411 - Solved Hover Color Matching in Navbar and Enhanced Navbar on Home Page

Please review and merge this PR.

@sunny0625 @khushi-joshi-05

Description

Earlier, In Navbar on hovering the links, it matches the background color, so I solved that.

Also enhanced the navbar with proper spacing, removing duplications, color of the text, size and giving transition effect in the links.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Before :
Screenshot 2024-07-08 210846

After :
Screenshot 2024-07-08 210935

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

github-actions bot commented Jul 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for foodies-ordering-website ready!

Name Link
🔨 Latest commit 4a43826
🔍 Latest deploy log https://app.netlify.com/sites/foodies-ordering-website/deploys/669bd42f57478b0008301617
😎 Deploy Preview https://deploy-preview-1316--foodies-ordering-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jency1
Copy link
Contributor Author

jency1 commented Jul 9, 2024

@sunny0625 Please review and merge this PR. I have solved the issue.

@sunny0625 sunny0625 linked an issue Jul 10, 2024 that may be closed by this pull request
@sunny0625 sunny0625 added gssoc GSSOC'24 issues wontfix This will not be worked on and removed gssoc GSSOC'24 issues labels Jul 10, 2024
@sunny0625
Copy link
Collaborator

image
Solve this..!
see your changes in 😎 Deploy Preview.

@jency1
Copy link
Contributor Author

jency1 commented Jul 10, 2024

image Solve this..! see your changes in 😎 Deploy Preview.

@sunny0625 Thanks for informing to see the changes in Deploy Preview.

Now, I have resolved all the issues, Do check it and merge this PR.

@jency1
Copy link
Contributor Author

jency1 commented Jul 11, 2024

@sunny0625 I have resolved all the issues, Do check it and merge this PR.

@jency1
Copy link
Contributor Author

jency1 commented Jul 12, 2024

@sunny0625 @khushi-joshi-05 I have resolved all the issues, Please Do check it and merge this PR as soon as possible. Also add the level label.

Thank you.

@sunny0625
Copy link
Collaborator

solve conflicts.

@jency1
Copy link
Contributor Author

jency1 commented Jul 14, 2024

solve conflicts.

@sunny0625 I have resolved the conflict issue. Do check it once and merge this PR by adding the level labels.

Thank you.

@jency1
Copy link
Contributor Author

jency1 commented Jul 15, 2024

@sunny0625 I have resolved the conflict issue. Do check it once and merge this PR by adding the level label.

@jency1
Copy link
Contributor Author

jency1 commented Jul 15, 2024

@sunny0625 I have resolved the conflict issue. Do check it once and merge this PR.

@sunny0625
Copy link
Collaborator

image
@khushi-joshi-05 @jency1

@sunny0625 sunny0625 added gssoc GSSOC'24 issues level1 and removed wontfix This will not be worked on labels Jul 16, 2024
@sunny0625
Copy link
Collaborator

solve conflicts.

@jency1
Copy link
Contributor Author

jency1 commented Jul 20, 2024

@sunny0625 I have resolved all the conflict issues. I have Removed all the duplicate links in navbar and enhanced the navbar.

Do check it and merge this PR as soon as possible along with the labels.

Here is the attached screenshot for your reference.

Screenshot 2024-07-20 204458

@jency1
Copy link
Contributor Author

jency1 commented Jul 21, 2024

@sunny0625 I have resolved all the conflict issues. I have Removed all the duplicate links in navbar and enhanced the navbar.

Do check it and merge this PR as soon as possible along with the labels.

Here is the attached screenshot for your reference.

Screenshot 2024-07-20 204458

Please merge this PR. I have solved all the issues 5-6 times. @sunny0625 @khushi-joshi-05

@jency1
Copy link
Contributor Author

jency1 commented Jul 22, 2024

@sunny0625 @khushi-joshi-05 Please merge this PR as soon as possible. I have solved all the conflict issues 6-7 times.

@khushi-joshi-05 khushi-joshi-05 removed their request for review July 23, 2024 08:21
@khushi-joshi-05 khushi-joshi-05 merged commit 054321b into khushi-joshi-05:main Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC'24 issues level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover Color on Links Matches Background Color on Home Page
3 participants