Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made the continue shopping button work #1374

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

nandani-goyal
Copy link
Contributor

@nandani-goyal nandani-goyal commented Jul 17, 2024

Related Issue

#1286

Description

1)I have removed the shipping option from the below as the subtotal is now shown on the right side of the list.
2)connected the continue shopping button to the menu page.

Screen.Recording.2024-07-17.171806.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Security enhancement
  • Other (specify): _______________

Screenshots / Videos (if applicable)

before:
Screenshot 2024-07-17 171219
after changes::
Screenshot 2024-07-17 171737
made the logo and icon visible
before::
Screenshot 2024-07-17 181019
after::
image

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have followed the code style guidelines of this project.
  • I have checked for any existing open issues that my pull request may address.
  • I have ensured that my changes do not break any existing functionality.
  • Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
  • I have read the resources for guidance listed below.
  • I have followed security best practices in my code changes.

Additional Context

[Include any additional information or context that might be helpful for reviewers.]

Contribution Guidelines

Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:

Issue Creation

  1. Limit on Issues:
    • Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

  1. Basic Contributions:

    • This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
    • For these tasks, issues will be assigned the level1 label.
  2. Acknowledging Hard Work:

    • If a contributor puts in significant effort on a task, the issue will be upgraded to level2. This is our way of recognizing and appreciating extra effort.
  3. Feature Additions and Component Work:

    • Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
    • The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

  • Level1:
    • Tasks are straightforward, such as fixing minor bugs, writing tests, or making simple documentation updates.
  • Level2:
    • Tasks require more effort, such as addressing complex bugs, improving existing features, or making substantial documentation improvements.
  • Level3:
    • Tasks are highly complex and involve significant new feature development, major refactoring, or extensive contributions to the project’s core components.

We look forward to your contributions and appreciate your effort in helping us improve the project!

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for foodies-ordering-website ready!

Name Link
🔨 Latest commit 1624227
🔍 Latest deploy log https://app.netlify.com/sites/foodies-ordering-website/deploys/6697bc181a07810008f32c0f
😎 Deploy Preview https://deploy-preview-1374--foodies-ordering-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sunny0625 sunny0625 linked an issue Jul 18, 2024 that may be closed by this pull request
@sunny0625 sunny0625 added gssoc GSSOC'24 issues level1 labels Jul 18, 2024
@sunny0625 sunny0625 merged commit bcd3293 into khushi-joshi-05:main Jul 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC'24 issues level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improving the subtotal calculating feature of cart page
2 participants