Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Navbar bug, where the dark-light theme switching doesnt work as expected. #1541

Closed
wants to merge 0 commits into from

Conversation

Sourabh782
Copy link

Description

Fixed the Navbar bug, where the dark-light theme switching doesnt work as expected.
I have attached video samples of each change briefing the ORIGINAL navbar working and mine Corrected working for your reference.

Related Issues

There were bugs in navbar of every page in toggling dark-light mode, I fixed the toggling bus in every page's navbar and now the navbars of each page are working fine as expected
I have myself tested the theme change working of navbars at every page.

Pages that i have worked on includes :
Home page
Contact Us Page
Menu Page
Service Page
Rate Us Page
Offers Page
Login Page
Sign Up Page
My Cart Page

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

  1. Bug in contact us page Navbar:
    https://github.com/user-attachments/assets/ace3741d-6224-4180-939d-92abdf41afa9

resolved:
https://github.com/user-attachments/assets/4fbe3f55-5408-44f5-9f22-74eb2ceafe20

  1. Bug in Langing page Navbar:
    https://github.com/user-attachments/assets/29b39dba-c362-4003-806f-4f8616f63edd

resolved:
https://github.com/user-attachments/assets/8a00cbf5-bc69-4c1d-aacd-8324745d714a

  1. Bug in Menu page Navebar:
    https://github.com/user-attachments/assets/f60b3c6f-f6b0-4095-a0aa-86330ab96d2c

resolved:
https://github.com/user-attachments/assets/bc7f5262-8ef9-4788-968c-5be3e71b2c8f

  1. Bug in Service page Navbar:
    https://github.com/user-attachments/assets/3947fccd-17a4-4472-8fe1-17e430e94f67

resolved:
https://github.com/user-attachments/assets/021f5c15-aa49-41f8-a6ff-865d31bf488c

  1. bug in Rate Us Page Navbar:
    https://github.com/user-attachments/assets/62ad8473-d873-4c50-a6a3-786ea3398b3e

resolved:
https://github.com/user-attachments/assets/89e3527c-e33e-4570-9cff-4f70a4ef2fa5

  1. Bug in Offers page Navbar:
    https://github.com/user-attachments/assets/483f0287-6ee7-40a4-a5d4-0d9bb31dc138

resolved:
https://github.com/user-attachments/assets/b8215800-d7e3-40ee-bd7c-bb173625bd25

  1. Bug in Login Page Navbar
    resolved:
    https://github.com/user-attachments/assets/a3f9dec1-46df-43ee-90f4-db5dc8d1ad3f

  2. Bug in Mycart navbar:
    resolved:
    https://github.com/user-attachments/assets/cb0ad620-7c95-4390-b871-6f906ceabf2f

  3. Bug in signup page navbar:
    resolved:
    https://github.com/user-attachments/assets/48088fb0-c4b5-4693-b120-8fcec50633fc

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]
I have also changed the sun logo representing the day toggle option, As previous logo was not visible and created confusion.

Thanks for Assigning this issue to me, Hope for good results 👍

Copy link

github-actions bot commented Aug 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for foodies-ordering-website ready!

Name Link
🔨 Latest commit 8df3b3b
🔍 Latest deploy log https://app.netlify.com/sites/foodies-ordering-website/deploys/66b58aa239bbbf00083fbd55
😎 Deploy Preview https://deploy-preview-1541--foodies-ordering-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sunny0625 sunny0625 added the gssoc GSSOC'24 issues label Aug 2, 2024
@Sourabh782
Copy link
Author

@sunny0625 can u add relevant level tag?

@Sourabh782
Copy link
Author

can you check it @khushi-joshi-05 ?

@sunny0625
Copy link
Collaborator

solve conflicts.

@Sourabh782
Copy link
Author

@sunny0625 Resolved conflicts, kindly check

@sunny0625
Copy link
Collaborator

solve conflicts.

@Sourabh782 Sourabh782 closed this Aug 9, 2024
@Sourabh782
Copy link
Author

Hello @sunny0625, I will add new pr for this issue, it was generating unknown errors

@Sourabh782
Copy link
Author

@sunny0625, I have added a new PR #1601, which has no conflict. please check it
Screenshot 2024-08-09 095712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC'24 issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme change toggle issue (Nav Bar)
2 participants