[ui] apply new "infoStyle" where applicable #7921
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
info icons. This PR applies the styling across the UI. # Conflicts: # frontend/src/components/VirtualList/Renderers.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on to kiali7769, which introduced new global "infoStyle" for info icons. This PR applies the styling across the UI.
Testing:
@ferhoyos , I've clicked around to, I think, all of the affected places and it looks consistent to me. In some cases the margin is slightly reduced and in others it is slightly increased. If necessary we could adjust it globally in either direction. In a couple of places (like the "hide" inputs) I needed to remove some rightMargin so that we didn't combine rightMarging of the component with leftMargin of the info icon.