KIK-7588 - getPendingBalance for erc20 contract (kin) #15

yosriz · 2017-11-09T20:38:09Z

implement pending balance using ethereum events(logs) mechanism, fetch pending logs
and calculate from/to transaction amount
refactor consts to central place
update geth.aar to fixed version that supports pending logs
relevant geth fix is here: mobile, ethclient, core/types: enable filtering on pending/latest logs go-ethereum#1

* implement pending balance using ethereum events(logs) mechanism, fetch pending logs and calculate from/to transaction amount * refactor consts to central place * update geth.aar to fixed version that supports pending logs

yosriz · 2017-11-09T20:44:07Z

we should add somewhere known issue (readme.md? issues list?), that states that pending balance will not work with Geth nodes currently due to known bug :ethereum/go-ethereum#15359

YohayBar · 2017-11-12T08:44:15Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/KinConsts.java

+
+final class KinConsts {
+
+    private KinConsts() {


private KinConsts() ? can we place const in xml?

final and private ctor, a common pattern to create non-inheritable-instantiatable class, as it's just holder for consts.
as for xml, I'm not sure it will be better, xml are more for resources, and it will require to pass android Context everywhere (yuk..), on the other end, saving the abi json in code it also ugly.

maybe the the ABI can be placed in a json file, but it's another task.

YohayBar · 2017-11-12T08:52:11Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+
+            filterQuery.setAddresses(addresses);
+            filterQuery.setFromBlock(Geth.newBigInt(Geth.LatestBlockNumber));
+            filterQuery.setToBlock(Geth.newBigInt(Geth.PendingBlockNumber));


how does Geth knows what is the Geth.PendingBlockNumber and LatestBlockNumber ?

Geth don't know, eventually it's translated to special param in json RPC.
block param in json RPC can get block number or 'pending'/'latest'/'earliest', as geth API gets block number as BigInt there is a special consts to represent it. This consts exists also at geth Go part I just wrapped them to mobile.

YohayBar · 2017-11-12T08:55:06Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+        try {
+            String accountAddressHex = account.getAddress().getHex();
+
+            BigInteger pendingSpentAmount = getPendingSpentAmount(accountAddressHex);


there are 2 request to network node one for spent and one for earn - can it be combined into one request?

👍 , I need to check if it's can be combined to single request

we also asking the balance just before so it is 3 network calls to get pending balance :)

after additional look, seems we can't ☹️:
https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_newfilter
OR relation can be only inside to/from param (and putting to = everything OR something = everything)
so we can't do single query with: to = some_address, from = any address, OR to = any address, from = some_address.

OK good for now - will open a bonus task to see if there is way around it. (for example get all pending transaction in the contract without filtering to/from, and then filter to/from on client side (it is also more private))

YohayBar · 2017-11-12T08:56:08Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/EthClientWrapper.java


    public EthClientWrapper(android.content.Context androidContext, ServiceProvider serviceProvider) throws EthereumClientException {
        this.serviceProvider = serviceProvider;
        this.gethContext = new Context();
        initEthereumClient();
        initKinContract();
        initKeyStore(androidContext);
+        pendingBalanceResolver = new PendingBalanceResolver(ethereumClient, gethContext);


can we remove the word Resolver it is a bit ambiguous , PendingBalance is explanatory enough (IMO)

agreed, resolver is redundant

YohayBar · 2017-11-12T09:00:32Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+    private final EthereumClient ethereumClient;
+    private final Context gethContext;
+
+    PendingBalanceResolver(EthereumClient ethereumClient, Context gethContext) {


can we move this code to EthClientWrapper, do we really need PendingBalanceResolver as a separate class?

I think we should favour clean code principles, i.e. small, separate concern classes, adding this code to EthClientWrapper will make it ~400 lines (and we have just began...) which is recipe for hard to maintain convoluted code

Also can you add short documentation ? same to the methods inside.
it will be easier to understand the purpose of it.

added documentation, refactor a bit for having more clarity

YohayBar · 2017-11-12T09:14:36Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/EthClientWrapper.java

    private long nonce = -1;
    private BigInt gasPrice = null;
-
-    private static final String ABI = "[{\"constant\":true,\"inputs\":[],\"name\":\"name\",\"outputs\":[{\"name\":\"\",\"type\":\"string\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_newOwnerCandidate\",\"type\":\"address\"}],\"name\":\"requestOwnershipTransfer\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_spender\",\"type\":\"address\"},{\"name\":\"_value\",\"type\":\"uint256\"}],\"name\":\"approve\",\"outputs\":[{\"name\":\"\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"totalSupply\",\"outputs\":[{\"name\":\"\",\"type\":\"uint256\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_from\",\"type\":\"address\"},{\"name\":\"_to\",\"type\":\"address\"},{\"name\":\"_value\",\"type\":\"uint256\"}],\"name\":\"transferFrom\",\"outputs\":[{\"name\":\"\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"isMinting\",\"outputs\":[{\"name\":\"\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"decimals\",\"outputs\":[{\"name\":\"\",\"type\":\"uint8\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_to\",\"type\":\"address\"},{\"name\":\"_amount\",\"type\":\"uint256\"}],\"name\":\"mint\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[{\"name\":\"_owner\",\"type\":\"address\"}],\"name\":\"balanceOf\",\"outputs\":[{\"name\":\"balance\",\"type\":\"uint256\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[],\"name\":\"acceptOwnership\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"owner\",\"outputs\":[{\"name\":\"\",\"type\":\"address\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"symbol\",\"outputs\":[{\"name\":\"\",\"type\":\"string\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_to\",\"type\":\"address\"},{\"name\":\"_value\",\"type\":\"uint256\"}],\"name\":\"transfer\",\"outputs\":[{\"name\":\"\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"newOwnerCandidate\",\"outputs\":[{\"name\":\"\",\"type\":\"address\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_tokenAddress\",\"type\":\"address\"},{\"name\":\"_amount\",\"type\":\"uint256\"}],\"name\":\"transferAnyERC20Token\",\"outputs\":[{\"name\":\"success\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[{\"name\":\"_owner\",\"type\":\"address\"},{\"name\":\"_spender\",\"type\":\"address\"}],\"name\":\"allowance\",\"outputs\":[{\"name\":\"remaining\",\"type\":\"uint256\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[],\"name\":\"endMinting\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"anonymous\":false,\"inputs\":[],\"name\":\"MintingEnded\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"owner\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"spender\",\"type\":\"address\"},{\"indexed\":false,\"name\":\"value\",\"type\":\"uint256\"}],\"name\":\"Approval\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"to\",\"type\":\"address\"},{\"indexed\":false,\"name\":\"value\",\"type\":\"uint256\"}],\"name\":\"Transfer\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"_by\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"_to\",\"type\":\"address\"}],\"name\":\"OwnershipRequested\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"_from\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"_to\",\"type\":\"address\"}],\"name\":\"OwnershipTransferred\",\"type\":\"event\"}]";
+    private final PendingBalanceResolver pendingBalanceResolver;


geth.aar -can you also create a pr to kin foundation go-ethereum? someone can overwrite geth.aar revert your change and break this code

yes, sure, working on a separate PR on go-ethereum code

@yosriz can you add a link to the PR here

sure, added to PR comment

OrenZak · 2017-11-12T11:42:42Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/KinConverter.java

@@ -26,4 +27,8 @@ static BigDecimal toKin(BigDecimal value) {
    static BigDecimal toKin(BigInt value) {
        return new BigDecimal(value.string()).divide(KIN, 18, BigDecimal.ROUND_FLOOR);
    }
+
+    static BigDecimal toKin(BigInteger value) {
+        return new BigDecimal(value).divide(KIN, 18, BigDecimal.ROUND_FLOOR);


i guess it should be multiply by KIN to get the value, and we can use the method we already have. static BigDecimal toKin(BigDecimal value).

can you check it ?

checked, converting from wei (Kin smallest value) to Kin, so division is correct

OrenZak · 2017-11-12T12:15:42Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/EthClientWrapper.java

+
+    public Balance getPendingBalance(Account account) throws OperationFailedException {
+        Balance balance = getBalance(account);
+


line space redundant

OrenZak · 2017-11-12T12:26:08Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+        return sumTransactionsAmount(pendingEarnLogs);
+    }
+
+    private Logs getPendingTransactionsLogs(@Nullable String fromHex, @Nullable String toHex) throws OperationFailedException {


can we change the names: fromHex and toHex -> fromAddressHex, toAddressHex ?

Do we need to allow null for both of the Hex's ? (fromHex , toHex)

names changed.
it's possibile to get logs by filtering by all variations (null just means no filter), logically here we need either to/from to have value, so I don't see a point to enforce it

OrenZak · 2017-11-12T12:40:42Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+        return Geth.newHashFromHex("0x000000000000000000000000" + hexAddress.substring(2));
+    }
+
+    private BigInteger sumTransactionsAmount(Logs logs) throws Exception {


Can be replaced with BigDecimal instead ?

will be handled separately (when dealing with possible precision error)

OrenZak

see my comments

YohayBar · 2017-11-12T15:33:59Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/KinConsts.java

+
+    static final long DEFAULT_GAS_LIMIT = 4300000;
+    static final String ABI = "[{\"constant\":true,\"inputs\":[],\"name\":\"name\",\"outputs\":[{\"name\":\"\",\"type\":\"string\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_newOwnerCandidate\",\"type\":\"address\"}],\"name\":\"requestOwnershipTransfer\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_spender\",\"type\":\"address\"},{\"name\":\"_value\",\"type\":\"uint256\"}],\"name\":\"approve\",\"outputs\":[{\"name\":\"\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"totalSupply\",\"outputs\":[{\"name\":\"\",\"type\":\"uint256\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_from\",\"type\":\"address\"},{\"name\":\"_to\",\"type\":\"address\"},{\"name\":\"_value\",\"type\":\"uint256\"}],\"name\":\"transferFrom\",\"outputs\":[{\"name\":\"\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"isMinting\",\"outputs\":[{\"name\":\"\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"decimals\",\"outputs\":[{\"name\":\"\",\"type\":\"uint8\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_to\",\"type\":\"address\"},{\"name\":\"_amount\",\"type\":\"uint256\"}],\"name\":\"mint\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[{\"name\":\"_owner\",\"type\":\"address\"}],\"name\":\"balanceOf\",\"outputs\":[{\"name\":\"balance\",\"type\":\"uint256\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[],\"name\":\"acceptOwnership\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"owner\",\"outputs\":[{\"name\":\"\",\"type\":\"address\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"symbol\",\"outputs\":[{\"name\":\"\",\"type\":\"string\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_to\",\"type\":\"address\"},{\"name\":\"_value\",\"type\":\"uint256\"}],\"name\":\"transfer\",\"outputs\":[{\"name\":\"\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[],\"name\":\"newOwnerCandidate\",\"outputs\":[{\"name\":\"\",\"type\":\"address\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[{\"name\":\"_tokenAddress\",\"type\":\"address\"},{\"name\":\"_amount\",\"type\":\"uint256\"}],\"name\":\"transferAnyERC20Token\",\"outputs\":[{\"name\":\"success\",\"type\":\"bool\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":true,\"inputs\":[{\"name\":\"_owner\",\"type\":\"address\"},{\"name\":\"_spender\",\"type\":\"address\"}],\"name\":\"allowance\",\"outputs\":[{\"name\":\"remaining\",\"type\":\"uint256\"}],\"payable\":false,\"type\":\"function\"},{\"constant\":false,\"inputs\":[],\"name\":\"endMinting\",\"outputs\":[],\"payable\":false,\"type\":\"function\"},{\"anonymous\":false,\"inputs\":[],\"name\":\"MintingEnded\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"owner\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"spender\",\"type\":\"address\"},{\"indexed\":false,\"name\":\"value\",\"type\":\"uint256\"}],\"name\":\"Approval\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"from\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"to\",\"type\":\"address\"},{\"indexed\":false,\"name\":\"value\",\"type\":\"uint256\"}],\"name\":\"Transfer\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"_by\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"_to\",\"type\":\"address\"}],\"name\":\"OwnershipRequested\",\"type\":\"event\"},{\"anonymous\":false,\"inputs\":[{\"indexed\":true,\"name\":\"_from\",\"type\":\"address\"},{\"indexed\":true,\"name\":\"_to\",\"type\":\"address\"}],\"name\":\"OwnershipTransferred\",\"type\":\"event\"}]";
+    static final String CONTRACT_ADDRESS_HEX = "0xEF2Fcc998847DB203DEa15fC49d0872C7614910C";


we need both testnet contract address and main net - the code need to select the right one based on network id

yes, that's a problem, I opened a different task for it

YohayBar · 2017-11-13T08:24:06Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+        BigInteger totalAmount = BigInteger.ZERO;
+        for (int i = 0; i < logs.size(); i++) {
+            Log log = logs.get(i);
+            String txHash = log.getTxHash().getHex();


why checking txHash !=null if using log.getData()?

that's the minimum required check I think, if transaction doesn't have a hash, we dropped it

YohayBar · 2017-11-13T08:25:22Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+    }
+
+    private BigInteger getPendingSpentAmount(String accountAddressHex) throws Exception {
+        Logs pendingSpentLogs = getPendingTransactionsLogs(accountAddressHex, null);


can we add tests for this method right now?

yes, I think there's a chance, it will need to be Android test, but I guess mocking the rest is not that hard

YohayBar · 2017-11-13T08:27:14Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+            if (fromHex != null) {
+                hashes.append(hexAddressToTopicHash(fromHex));
+            }
+            topics.append(hashes);


if fromHex == null do we need topics.append(hashes); hashes = Geth.newHashesEmpty();

yes, because we need to specify null in the param, in case we don't want to filter according to this param, and also the order is important.
I'm adding a comment to explain exactly how the topics is constructed, so it will be clear.

YohayBar · 2017-11-13T08:27:38Z

kin-sdk-core/src/main/java/kin/sdk/core/ethereum/PendingBalanceResolver.java

+            if (toHex != null) {
+                hashes.append(hexAddressToTopicHash(toHex));
+            }
+            topics.append(hashes);


see previous comment

YohayBar · 2017-11-13T12:56:16Z

.gitignore

@@ -37,7 +37,7 @@ captures/
 *.iml
 .idea/*
 # ...but keep these
-!.idea/intellij-java-google-style.xml
+!.idea/codeStyleSettings.xml


? make sure this change is correct ???

@yosriz looks like there is something wrong with your merge ...
These changes are already in dev

yes, miserable mistake, for syncing with dev I merged from the wrong branch (not from dev), fixed that now, and unfortunately had to do push force

YohayBar · 2017-11-13T13:06:56Z

sample/src/main/java/kin/sdk/core/sample/MainActivity.java

@@ -35,7 +35,7 @@ private void initKinClient() {
        String infuraToken = "yourinfuratoken";
        try {
            kinClient = new KinClient(getApplicationContext(),
-                    new ServiceProvider(INFURA_ROPSTEN_BASE_URL + infuraToken, ServiceProvider.NETWORK_ID_ROPSTEN));
+                new ServiceProvider(INFURA_ROPSTEN_BASE_URL + infuraToken, ServiceProvider.NETWORK_ID_ROPSTEN));


change node to our parity server

YohayBar

Overall 👍 see last 2 comment before merging

YohayBar · 2017-11-13T13:08:39Z

@yosriz @OrenZak request changes make sure he also approve

* fix code review comments * rename methods KinConverter to reflect better their job

…nting_get_pending_balance

OrenZak

👍

KIK-7588 - getPendingBalance for erc20 contract (kin)

a69ee10

* implement pending balance using ethereum events(logs) mechanism, fetch pending logs and calculate from/to transaction amount * refactor consts to central place * update geth.aar to fixed version that supports pending logs

YohayBar reviewed Nov 12, 2017

View reviewed changes

OrenZak reviewed Nov 12, 2017

View reviewed changes

OrenZak suggested changes Nov 12, 2017

View reviewed changes

YohayBar reviewed Nov 12, 2017

View reviewed changes

YohayBar reviewed Nov 13, 2017

View reviewed changes

YohayBar approved these changes Nov 13, 2017

View reviewed changes

yosriz added 2 commits November 13, 2017 15:16

KIK-7588 - getPendingBalance for erc20 contract (kin)

c0c6b51

* fix code review comments * rename methods KinConverter to reflect better their job

Merge remote-tracking branch 'origin/dev' into yossi/KIK-7588_impleme…

87e8b3c

…nting_get_pending_balance

yosriz force-pushed the yossi/KIK-7588_implementing_get_pending_balance branch from 4930d9b to 87e8b3c Compare November 13, 2017 13:28

OrenZak approved these changes Nov 13, 2017

View reviewed changes

yosriz merged commit 3cff6b8 into dev Nov 13, 2017

OrenZak deleted the yossi/KIK-7588_implementing_get_pending_balance branch November 16, 2017 12:05


		public Balance getPendingBalance(Account account) throws OperationFailedException {
		Balance balance = getBalance(account);

KIK-7588 - getPendingBalance for erc20 contract (kin) #15

KIK-7588 - getPendingBalance for erc20 contract (kin) #15

Conversation

yosriz commented Nov 9, 2017 • edited Loading

yosriz commented Nov 9, 2017

YohayBar Nov 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YohayBar Nov 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OrenZak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YohayBar Nov 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YohayBar left a comment

Choose a reason for hiding this comment

YohayBar commented Nov 13, 2017

OrenZak left a comment

Choose a reason for hiding this comment

yosriz commented Nov 9, 2017 •

edited

Loading

YohayBar Nov 12, 2017 •

edited

Loading

YohayBar Nov 12, 2017 •

edited

Loading

YohayBar Nov 13, 2017 •

edited

Loading