added pagination, modified events.controller and events.service in Fi… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tschonti
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Nice, works perfectly!
Just one thing, unfortunately swagger can't detect the optional parameters in the controller method, so it treats the query params as required.
this can be fixed with an @apiquery decorator
https://stackoverflow.com/questions/72131909/nestjs-typeorm-optional-query-not-working
|
just a quick ping here, don't forget this, only a small fix is required @pem00 |
Tschonti
reviewed
Jul 24, 2024
Comment on lines
20
to
39
| async findAll(): Promise<Event[]> { | ||
| return this.eventsService.findAll(); | ||
| @ApiQuery({ name: 'skip', type: Number }) | ||
| @ApiQuery({ name: 'take', type: Number }) | ||
| async findAll( | ||
| @Query('skip', new DefaultValuePipe(0), ParseIntPipe) skip?: number, | ||
| @Query('take', new DefaultValuePipe(10), ParseIntPipe) take?: number | ||
| ): Promise<Event[]> { | ||
| return this.eventsService.findAll(take, skip); | ||
| } |
There was a problem hiding this comment.
the DefaultValuePipe is a nice addition, but please also add the required: false flag to the @ApiQuery-s, so that swagger will allow empty values (and then the default value will be used)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added pagination to event findall() using Offset pagination in events.service.ts, using the endDate dates for the descending order