moved mililitre field #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtagh27
requested review from
a team,
Tschonti,
LeventeFarkashazi,
pem00 and
VarMattew
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tschonti
requested changes
Sep 26, 2024
There was a problem hiding this comment.
You modified the prisma schema but you didn't create migrations (or at least didn't commit them). This could cause issues later, so remember to always create migration files when you edit the schema (yarn prisma migrate dev there are already some inconsistencies in our migration files, so you might have to delete the migrations directory first. this is fine for now, since our app is not in production). I added a workflow to automatically fail all future PRs if the schema is edited but no migrations were added.
the rest of it is good
|
oh i created them, but for some reason i thought i shouldnt push them, sorry-.- |
…Alcoholic into move-millilitre-field
4 tasks
Tschonti
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.