Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Item dialog #43

Closed
captainwasabi opened this issue Oct 22, 2014 · 6 comments
Closed

Edit Item dialog #43

captainwasabi opened this issue Oct 22, 2014 · 6 comments
Assignees
Milestone

Comments

@captainwasabi
Copy link

In the Edit Item dialog the "Edit Item" button should probably just be a "Save" button, or "Save Item"

@kiswa
Copy link
Owner

kiswa commented Oct 22, 2014

I'll consider it, but at first thought I'm in agreement with you.

@kiswa kiswa added this to the v0.3.0 milestone Oct 22, 2014
@kiswa kiswa self-assigned this Oct 22, 2014
@alex3305
Copy link
Contributor

I think Save should be the best way to go. It's simple and easy to understand. Than again you could also go for a glyphicon that is included in Bootstrap.

@kiswa
Copy link
Owner

kiswa commented Oct 23, 2014

I've used Font Awesome icons in TaskBoard, but yeah it might be good to add them to the buttons. I do think I'll update this to Save Item... and probably go through them all to see if others could be improved.

@captainwasabi
Copy link
Author

This also applies to all places where you are editing something. (I edited a board and the save button says "Edit Board" and should say "Save" or "Save Board")

@kiswa
Copy link
Owner

kiswa commented Oct 23, 2014

go through them all to see if others could be improved

Yeah, I'm planning to check them all. ;)

@kiswa kiswa modified the milestones: v0.2.4, v0.3.0 Oct 25, 2014
@kiswa kiswa closed this as completed Oct 25, 2014
@kiswa
Copy link
Owner

kiswa commented Oct 25, 2014

Added icons too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants