-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 Added new methods and inline methods #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=============================================
- Coverage 62.50% 50.00% -12.50%
Complexity 8 8
=============================================
Files 4 5 +1
Lines 144 144
Branches 41 38 -3
=============================================
- Hits 90 72 -18
- Misses 46 67 +21
+ Partials 8 5 -3
Continue to review full report at Codecov.
|
Wow!!! Thanks for this 👏. Let me take a look on this. |
@Globegitter Thanks soooo much! I agree with you I think this is a great addition to the library! I think we need 4.0 for this though. but I am happy to bump this up to improve the usage of |
Awesome, happy to hear that we can get this in :) And yes makes sense to release as 4.0 |
@kittinunf anything still blocking the merge? Would love to upgrade one of our new projects to the new version asap :) I am also not sure why codecov is saying that certain lines are not covered when my tests clearly are covering them. Any idea? |
I don't care too much about the codecov no worries. Yes let me check one more time but I think it is pretty much good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is golden, let me merge and prepare for 4.0
This adds most of the methods and changes we have been using internally and we think really improves the usability of this library and fixes an imo very important bug we ran into a lot at the beginning in production and is not super easy to debug if you are not aware of it: #59
One nice thing about having all these inline methods it basically means that we do not need a separate coroutines result but that one can work out of the box with coroutines as you can see in the
.map
test I added.I know this PR adds a lot at once, I am also happy to split it up and I guess it would require a 4.0 release. Let me know what you think @kittinunf .