liftResult feature. #80 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittinunf
reviewed
Aug 11, 2021
result/src/commonMain/kotlin/com/github/kittinunf/result/Result.kt
Outdated
Show resolved
Hide resolved
… decide the returned Result
…success and errors and the returned Result. Refactored lift to use liftResult with a default implementation.
|
Please allow me to let the CI run the test! I think it is perfect as it is. |
kittinunf
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature requested #80
Added extension method liftSuccess to lift List<Result, E> into Result<List, E> where the returned Result is always success and applies a callback function when there are any errors in List
Thank you for your time and for this awesome project :)