Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature] Add requested feature with transformation for both value and error #96

Merged
merged 6 commits into from
Aug 16, 2021

Conversation

kittinunf
Copy link
Owner

@kittinunf kittinunf commented Aug 11, 2021

What's in this PR?

This PR adds feature request for mapBoth to be able to transform the type for both sides of the Type.

@kittinunf kittinunf requested a review from lopes-felipe August 12, 2021 06:35
@kittinunf kittinunf self-assigned this Aug 12, 2021
Copy link
Collaborator

@lopes-felipe lopes-felipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature!

@iNoles
Copy link
Collaborator

iNoles commented Aug 13, 2021

JS doesn't like `` on function with whitespace

@kittinunf kittinunf requested a review from lopes-felipe August 16, 2021 15:22
@kittinunf
Copy link
Owner Author

Thanks! @lopes-felipe

@kittinunf kittinunf changed the title [Feature] Add requested feature with transformation for both value and error ✨ [Feature] Add requested feature with transformation for both value and error Aug 16, 2021
@kittinunf kittinunf merged commit c58314b into master Aug 16, 2021
@kittinunf kittinunf deleted the kv/add-map-both-for-transformation branch August 16, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants