Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling Fuel from Central complains about missing Result, due to missing version #757

Closed
DanySK opened this issue Jun 22, 2020 · 11 comments
Closed
Assignees

Comments

@DanySK
Copy link

DanySK commented Jun 22, 2020

Bug Report

Description

When using central and using Fuel this way:

repositories {
    mavenCentral()
}
dependencies {
    implementation("com.github.kittinunf.fuel:fuel:+")
    implementation("com.github.kittinunf.fuel:fuel-coroutines:+")
    implementation("com.github.kittinunf.fuel:fuel-gson:+")
}

Gradle complains:

* What went wrong:
Execution failed for task ':compileKotlin'.
> Could not resolve all files for configuration ':compileClasspath'.
   > Could not find com.github.kittinunf.result:result:2.2.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/com/github/kittinunf/result/result/2.2.0/result-2.2.0.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project : > com.github.kittinunf.fuel:fuel:2.2.3

This is caused by the fact that the first version of Result published on Central (thanks to kittinunf/Result#70) is 3.0.1.

Proposed solution

I suggest tackling this in two rather straightforwards steps:

  1. Make the current Fuel depend on Result 3.0.1
  2. Release a new version of Fuel

Since Central enforces a no-retract policy, it's impossible to change the current version to point to Result 3.0.1, a new release is thus necessary.

Alternate solution

Manually releasing result 2.2.0 on Central would work as well, but that requires manual intervention, and thus precious human time.

Temporary workaround

Who is currently using Fuel via Central can work around the issue by enforcing a compile-time dependency on Result (warning: it taints the dependency tree)

dependencies {
    implementation("com.github.kittinunf.result:result:3.0.1")
}
DanySK added a commit to DanySK/upgradle that referenced this issue Jun 22, 2020
@DanySK
Copy link
Author

DanySK commented Jun 22, 2020

Example work around here: DanySK/upgradle@fe6afc1

@kittinunf
Copy link
Owner

I will take care of this 🙇 sorry for inconveniences 🙏

@DanySK
Copy link
Author

DanySK commented Jun 23, 2020

Thank you @kittinunf 🙏 🙇

@nfrankel
Copy link

nfrankel commented Aug 1, 2020

Hello

Any way to help? I cannot override the dependency as a workaround, as I'm using Kotlin Scripting.

@kittinunf
Copy link
Owner

@nfrankel Let me help you out by manually pushing 2.2.0 to the maven central 🙇

@nfrankel
Copy link

nfrankel commented Aug 9, 2020

Thanks a lot @kittinunf! However, in the meantime, I switched to OkHttp because I was blocked: the override workaround doesn't work in the context of Kotlin Scripting

@kittinunf
Copy link
Owner

@nfrankel Oh no, sorry for the delay :( I will try to be more promptly support next time 🙇

@nfrankel
Copy link

nfrankel commented Aug 9, 2020

@kittinunf No worries! This is your personal Open Source project, I don't expect timely support.

Keep up the good work

@jayveeravalli
Copy link

@kittinunf any update on this? I am facing the same error for version 2.2.3

@kittinunf
Copy link
Owner

We have released new version 2.3.0 and it will reference the Result library (3.1.0) from the mavenCentral. It should take a few hours or so for everyone to be able to fetch! 🙇 🙇 🙇

DanySK added a commit to DanySK/upgradle that referenced this issue Sep 23, 2020
github-actions bot pushed a commit to DanySK/upgradle that referenced this issue Sep 23, 2020
github-actions bot pushed a commit to DanySK/upgradle that referenced this issue Sep 27, 2020
DanySK added a commit to DanySK/upgradle that referenced this issue Sep 27, 2020
@kittinunf
Copy link
Owner

I think this should solve all of the problem regarding to version on mavenCentral. 🙇 🙇 Feel free to re-open if this doesn't fix your issue. Otherwise, please let me close this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants