-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup HttpClient #639
Cleanup HttpClient #639
Conversation
interpretResponseStream should have InputStream as nullable. Move hook.httpExchangeFailed to different area.
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
=========================================
Coverage ? 71.39%
Complexity ? 297
=========================================
Files ? 57
Lines ? 1489
Branches ? 192
=========================================
Hits ? 1063
Misses ? 334
Partials ? 92
Continue to review full report at Codecov.
|
fuel/src/main/kotlin/com/github/kittinunf/fuel/toolbox/HttpClient.kt
Outdated
Show resolved
Hide resolved
fuel/src/main/kotlin/com/github/kittinunf/fuel/toolbox/HttpClient.kt
Outdated
Show resolved
Hide resolved
This looks like it is good to go, right? 😄 |
@SleeplessByte it is ready to merge with your suggestions. Sent with GitHawk |
Description
HttpClient deserve to be refracting with many areas. As for Hook, InputStream is now nullable. I am moving httpExchangeFailed to the different area. I added the connect() to make sure it is connected. I am planning to add more later on.
Type of change
Check all that apply
How Has This Been Tested?
In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.
Checklist: