Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe fix curlString #664

Merged
merged 3 commits into from
Aug 3, 2019
Merged

Maybe fix curlString #664

merged 3 commits into from
Aug 3, 2019

Conversation

SleeplessByte
Copy link
Collaborator

Please try this @NikkyAI

Description

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@SleeplessByte SleeplessByte requested a review from NikkyAI July 30, 2019 12:44
@NikkyAI
Copy link
Collaborator

NikkyAI commented Jul 30, 2019

it seems to work now, i will add some regression tests later to verify it too

@iNoles
Copy link
Collaborator

iNoles commented Jul 30, 2019

Some how, Travis CI removed sdkmanager.

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #664 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #664      +/-   ##
============================================
+ Coverage     71.39%   71.44%   +0.05%     
+ Complexity      297      296       -1     
============================================
  Files            57       58       +1     
  Lines          1489     1492       +3     
  Branches        192      192              
============================================
+ Hits           1063     1066       +3     
  Misses          334      334              
  Partials         92       92
Impacted Files Coverage Δ Complexity Δ
...github/kittinunf/fuel/core/requests/DefaultBody.kt 87.17% <ø> (-0.33%) 18 <0> (-1)
...ithub/kittinunf/fuel/core/extensions/Formatting.kt 90% <100%> (+1.11%) 0 <0> (ø) ⬇️
...main/kotlin/com/github/kittinunf/fuel/core/Body.kt 100% <100%> (ø) 0 <0> (?)
...hub/kittinunf/fuel/core/requests/RepeatableBody.kt 83.33% <100%> (+1.51%) 8 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b1f5a...34d96f4. Read the comment docs.

Copy link
Collaborator

@NikkyAI NikkyAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@iNoles iNoles merged commit 24c5ce1 into master Aug 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the SleeplessByte-patch-1 branch August 3, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants