Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed HTTPClient Response Message #670

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Fixed HTTPClient Response Message #670

merged 1 commit into from
Aug 10, 2019

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented Aug 8, 2019

Description

Damn platform types!!!! I wish there is a way to check those.

Fixes #669

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@iNoles iNoles requested a review from kittinunf August 8, 2019 20:18
@iNoles iNoles self-assigned this Aug 8, 2019
@iNoles iNoles changed the title Update HttpClient.kt Fixed HTTPClient Response Message Aug 8, 2019
@iNoles
Copy link
Collaborator Author

iNoles commented Aug 9, 2019

Some how, it caused response to look longer than normal. It may need rebuild.

@iNoles iNoles requested a review from SleeplessByte August 9, 2019 18:54
Copy link
Owner

@kittinunf kittinunf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@SleeplessByte
Copy link
Collaborator

Note: Travis is failing. I re-ran twice. Should probably try to fix it before merge.

@iNoles
Copy link
Collaborator Author

iNoles commented Aug 10, 2019

Push one is just Test Failure.

com.github.[secure].fuel.core.requests.CancellableRequestTest > testCancellationDuringSendingRequest FAILED

java.lang.AssertionError at CancellableRequestTest.kt:47

@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #670 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #670      +/-   ##
============================================
- Coverage     71.39%   71.32%   -0.07%     
  Complexity      296      296              
============================================
  Files            58       58              
  Lines          1496     1496              
  Branches        193      194       +1     
============================================
- Hits           1068     1067       -1     
  Misses          334      334              
- Partials         94       95       +1
Impacted Files Coverage Δ Complexity Δ
...in/com/github/kittinunf/fuel/toolbox/HttpClient.kt 74.77% <0%> (-0.91%) 28 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 781be0f...7d5f906. Read the comment docs.

@iNoles iNoles merged commit 3786703 into master Aug 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the iNoles-patch-1 branch August 10, 2019 05:43
@SleeplessByte
Copy link
Collaborator

So why wasn't that test failure fixed?

@iNoles
Copy link
Collaborator Author

iNoles commented Aug 10, 2019

So why wasn't that test failure fixed?

@SleeplessByte well, it is always randomly failing

Sent with GitHawk

@bagage
Copy link

bagage commented Aug 22, 2019

@iNoles any chance to release a 2.2.1 then? 2.2.0 is unusable right now. Thanks!

@iNoles
Copy link
Collaborator Author

iNoles commented Aug 22, 2019

@iNoles any chance to release a 2.2.1 then? 2.2.0 is unusable right now. Thanks!

Ask @kittinunf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests to localhost stop working in 2.2.0
4 participants