-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed HTTPClient Response Message #670
Conversation
Some how, it caused response to look longer than normal. It may need rebuild. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Note: Travis is failing. I re-ran twice. Should probably try to fix it before merge. |
Push one is just Test Failure. com.github.[secure].fuel.core.requests.CancellableRequestTest > testCancellationDuringSendingRequest FAILED
|
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
============================================
- Coverage 71.39% 71.32% -0.07%
Complexity 296 296
============================================
Files 58 58
Lines 1496 1496
Branches 193 194 +1
============================================
- Hits 1068 1067 -1
Misses 334 334
- Partials 94 95 +1
Continue to review full report at Codecov.
|
So why wasn't that test failure fixed? |
@SleeplessByte well, it is always randomly failing Sent with GitHawk |
@iNoles any chance to release a 2.2.1 then? 2.2.0 is unusable right now. Thanks! |
Ask @kittinunf |
Description
Damn platform types!!!! I wish there is a way to check those.
Fixes #669
Type of change
Check all that apply
How Has This Been Tested?
In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.
Checklist: