Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #667: use wrapped OutputStream batch write in ProgressOutputStrea… #675

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

tfactor2
Copy link

Description

This fixes the slowness described in #667 even if progress callback is used - ProgressOutputStream now uses wrapped OutputStream write(byte[] b, int off, int len) directly as FilterOutputStream implementation is not efficient .

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #675 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #675   +/-   ##
=========================================
  Coverage     71.32%   71.32%           
  Complexity      296      296           
=========================================
  Files            58       58           
  Lines          1496     1496           
  Branches        194      194           
=========================================
  Hits           1067     1067           
  Misses          334      334           
  Partials         95       95
Impacted Files Coverage Δ Complexity Δ
...github/kittinunf/fuel/util/ProgressOutputStream.kt 80% <100%> (ø) 2 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b08a4...c8ce5b0. Read the comment docs.

@iNoles iNoles requested a review from SleeplessByte August 13, 2019 17:55
Copy link
Collaborator

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are still green so I am assuming this will nog break anyone's code :)

@SleeplessByte SleeplessByte merged commit db62aec into kittinunf:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants