Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add POM information required by Maven Central #750

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

DanySK
Copy link

@DanySK DanySK commented Jun 4, 2020

Description

Should help with #747:

Project name missing, Project description missing, Project URL missing, SCM URL missing, Developer information missing

Project name, description, URL, SCM URL, and dev information has been added.

Type of change

Check all that apply

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (a change which changes the current internal or external interface)
  • This change requires a documentation update

Checklist:

  • [ X ] I have performed a self-review of my own code
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • [ X ] I have made corresponding changes to the documentation, if necessary
  • My changes generate no new compiler warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Inspect the bytecode viewer, including reasoning why

Should help with kittinunf#747:

`Project name missing, Project description missing, Project URL missing, SCM URL missing, Developer information missing`

Project name, description, URL, SCM URL, and dev information has been added.
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #750   +/-   ##
=========================================
  Coverage     72.71%   72.71%           
  Complexity      301      301           
=========================================
  Files            61       61           
  Lines          1510     1510           
  Branches        205      205           
=========================================
  Hits           1098     1098           
  Misses          311      311           
  Partials        101      101           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1453ec...43dfd0c. Read the comment docs.

@kittinunf
Copy link
Owner

@DanySK Thanks soooo much for doing this! Please allow me to merge this, I will add the rest of the contributors in the next PR. If you don't mind.

@kittinunf kittinunf changed the title Add POM information required by Maven Central 📝 Add POM information required by Maven Central Jun 5, 2020
@kittinunf kittinunf merged commit 150f6b7 into kittinunf:master Jun 5, 2020
@DanySK DanySK deleted the patch-1 branch June 5, 2020 13:17
@DanySK
Copy link
Author

DanySK commented Jun 5, 2020

@kittinunf no problem at all, it's on my best interest to have fuel available on Central as soon as possible :)
Let me know if #747 is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants