Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kotlin, Gradle, OkHTTP and KotlinX. #864

Merged
merged 1 commit into from
May 6, 2023
Merged

Upgrade Kotlin, Gradle, OkHTTP and KotlinX. #864

merged 1 commit into from
May 6, 2023

Conversation

iNoles
Copy link
Collaborator

@iNoles iNoles commented May 5, 2023

  1. Upgrade Kotlin to 1.8.21
  2. Upgrade Gradle to 8.0.2
  3. Upgrade OKHTTP with Async methods
  4. Upgrade Kotlinx coroutines to 1.7.0

@iNoles iNoles requested a review from kittinunf May 5, 2023 21:00
@iNoles iNoles self-assigned this May 5, 2023
Copy link
Owner

@kittinunf kittinunf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@@ -1,5 +1,5 @@
plugins {
kotlin("multiplatform") version "1.8.10" apply false
kotlin("multiplatform") version "1.8.21" apply false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not related to the change in this PR, do you think we can move this version into toml file instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that with the next PR. Thanks to Gradle 8.0 for a better version catalog.

@iNoles iNoles merged commit e4081cf into main May 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the update_okhttp branch May 6, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants