fix non-working loop when lowerLimit equals 0 #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Loop stuck on upperLimit when loop:true and lowerLimit presented but equals 0, expected behavior that it will go to lower limit when it's presented.
I believe it's a bug 🤔
I think it would be nice if we could extend it to go to start (initial ) value if loop:true but lower limit not presented
you can test those cases here (wanted to record some gifs but something wrong with my gif recorder 😞 )
https://codesandbox.io/s/suspicious-bohr-m90pp7?file=/src/App.tsx
Solution
what was done in this PR:
let me know WDYT about it 😄
P.S I'm a big fan of this library and always wanted to made something for it 😄 looks like it's my chance 😄