Grapheme clusters #838
Grapheme clusters #838
Conversation
In case a cross-platform terminal like WezTerm is used
| Ok("iTerm.app") => GraphemeClusterMode::Unicode, | ||
| Ok("WezTerm") => GraphemeClusterMode::Unicode, | ||
| Err(std::env::VarError::NotPresent) => match std::env::var("TERM").as_deref() { | ||
| Ok("xterm-kitty") => GraphemeClusterMode::NoZwj, |
There was a problem hiding this comment.
It is almost perfect. The one issue I had was with Kitty (on Debian):
This seems to work better with:
| Ok("xterm-kitty") => GraphemeClusterMode::NoZwj, | |
| Ok("xterm-kitty") => GraphemeClusterMode::Unicode, |
There was a problem hiding this comment.
Maybe the rendering varies depending on the platform / font used by Kitty ?
Because, I am almost sure that I tested kitty on MacOS. I will double check.
And, on Windows, all seems wrong:
Alacritty ~ (TERM=xterm-256color)
contour ~ (TERMINAL_NAME=contour)
WezTerm ~
Windows Terminal ~
But anyway, thanks for your feedback.
There was a problem hiding this comment.
On MacOS, kitty seems fine:
(at least rustyline behaves like zsh)
Should we add #[cfg(target_os = "macos")] on Ok("xterm-kitty") => GraphemeClusterMode::NoZwj, ?
There was a problem hiding this comment.
I tried changing the font for Kitty, but my understanding is that it just automatically use a fallback font for emojis if it is not present in the provided font.
I suspect that the issue I have observed does depend on the installed font, and I do not see how this could be handled 100% of the time. When testing in xfce4-terminal, My guess is that the underlying terminal emulator (GNOME’s vte) does something that prevent the combination of the separate emojis, regardless of the font. It is unclear whether that is intentional, but it does mean that the behavior stays consistent accross installations.
Anyway, having a bunch of empty space next to the character is not a terrible failure case. It is probably better than the original behavior where it was hard to know what you were even typing. So, probably a worthwile trade-off.
|
Wezterm is almost good on Windows (except 👩🏼👨🏼👦🏼👦🏼): |
See #826