Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer rewrite-clj deprecates edn* #247

Closed
palfrey opened this issue Jul 24, 2022 · 4 comments
Closed

Newer rewrite-clj deprecates edn* #247

palfrey opened this issue Jul 24, 2022 · 4 comments

Comments

@palfrey
Copy link

palfrey commented Jul 24, 2022

See clj-commons/rewrite-clj#178 which results in

----- ERROR -------------------------------------------------------------------
 File: jar:file:/home/palfrey/.m2/repository/zprint/zprint/1.2.3/zprint-1.2.3.jar!/zprint/zutil.cljc:200:50
--------------------------------------------------------------------------------
 197 |     (when (not (nil? nloc))
 198 |       (if (zthing? nloc) i (recur (zrightnws nloc) (inc i))))))
 199 |
 200 | (defn znl [] "Return a zloc which is a newline." (edn* (p/parse-string "\n")))
--------------------------------------------------------^-----------------------
null
rewrite-clj.zip/edn* is deprecated
{:warning :fn-deprecated, :line 200, :column 50, :msg "rewrite-clj.zip/edn* is deprecated", :shadow.build.compiler/warning-as-error true}
ExceptionInfo: rewrite-clj.zip/edn* is deprecated
@kkinnear
Copy link
Owner

Thanks for reporting this. I'll update to the newer rewrite-clj and fix these functions in the next release. Which I keep hoping is soon, but I also keep getting more bugs to fix. I'm hoping in the next few weeks to do the 1.2.4 release. Hopefully this deprecation isn't blocking you from using zprint?

@palfrey
Copy link
Author

palfrey commented Jul 24, 2022

Nah, I've just downgraded the version of rewrite-clj my project is pulling in, as I didn't need any of the newer features anyways :)

@kkinnear
Copy link
Owner

kkinnear commented Aug 2, 2022

In release 1.2.4, just out now, the new rewrite-clj is used and edn* is gone. Thanks for pointing this out, I wasn't paying attention to the changes in rewrite-clj!

@palfrey
Copy link
Author

palfrey commented Aug 6, 2022

Thanks, this fixed my issue

@palfrey palfrey closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants