This repository has been archived by the owner on Nov 29, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was calling the fallback
update
method directly and so wasn't seeing anyoptimization. Call
updateIEEE
instead which includes the optimized path (andbypasses the unnecessary switch on the table vs just calling
Update
).@klauspost
cc @wvanbergen
This explains the confusion we ran into trying to benchmark IBM/sarama#527