Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added django 1.10 compatibility #70

Closed
wants to merge 15 commits into from
Closed

added django 1.10 compatibility #70

wants to merge 15 commits into from

Conversation

sv0
Copy link

@sv0 sv0 commented Jul 24, 2016

Changes:

  • removed request.REQUEST (replaced with request.POST)
  • use list of urls instead of 'patterns' in urls.py ( for Django >= 1.8).
  • 'django.conf.urls.patterns()' will be removed in Django 1.10

sv0 added 14 commits July 17, 2016 11:17
'django.conf.urls.patterns()' was removed in Django 1.10a1
django.conf.urls.patterns will be depricated in django 1.10
future, standard library, third-party libraries, other Django components,
local Django component, try/excepts.
Apply 'safe' filter to extra_settings string.
Without 'safe' filter 'extra_settings' looks like

    mySettings, {"previewParserPath": "/markdown/preview/"});

when using django_markdown with django 1.10b1
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 57.778% when pulling 286b12a on sv0:develop into 0c8081b on klen:develop.

e.g.
mySettings, {"previewParserPath": "/markdown/preview/"});
@coveralls
Copy link

Coverage Status

Coverage increased (+5.8%) to 63.983% when pulling e752e22 on sv0:develop into 0c8081b on klen:develop.

@filipeximenes
Copy link

@sv0 this project seems not be maintained anymore and the owner does not seem interested in even merging PRs or even answering messages. Your PR is very important, you should consider renaming the project and deploying it under this new name to PyPI so we can continue using it (just make sure you keep compatible licences and credits).

Consider the names:
django-markdown-fields
django-markdown-forms
django-markdown-utils

Hope to hear from you!

@CostantinoGrana
Copy link

@sv0 I agree with @filipeximenes. Please make your branch an official new project. It works perfectly.

@sv0
Copy link
Author

sv0 commented Aug 10, 2016

@filipeximenes @CostantinoGrana
OK.
I will do it just after returning from the vacation.

@sv0
Copy link
Author

sv0 commented Aug 25, 2016

I've created a new repository https://github.com/sv0/django-markdown-app for django-markdown application.

The package is also available on PyPI:
https://pypi.python.org/pypi/django-markdown-app

@filipeximenes unfortunately the name django-markdown-utils is already taken.
So I've chosen another one. I hope it's OK.

@filipeximenes
Copy link

@sv0 Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants