Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pkg): upgrade to chokidar 3 #105

Merged
merged 2 commits into from
Dec 3, 2019
Merged

chore(pkg): upgrade to chokidar 3 #105

merged 2 commits into from
Dec 3, 2019

Conversation

STRML
Copy link
Collaborator

@STRML STRML commented Jul 1, 2019

No external breaking changes I can find. Works in our projects.
Chokidar 3 has performance improvements:
https://github.com/paulmillr/chokidar/releases/tag/3.0.0

Requires Node 8+

Fixes #104

No external breaking changes I can find. Works in our projects.
Chokidar 3 has performance improvements:
https://github.com/paulmillr/chokidar/releases/tag/3.0.0

Requires Node 8+
@rohan-deshpande
Copy link

Would be great to get this merged to fix the chokidar security vulnerability

@STRML
Copy link
Collaborator Author

STRML commented Aug 11, 2019

@kmagiera, happy to merge if you like, but will need you to cut a release.

@STRML STRML merged commit f4fe126 into master Dec 3, 2019
@STRML STRML deleted the chore/chokidar-3 branch December 3, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated chokidar version causing dependency vulnerability
3 participants