Set babel sourcemap option to inline when debug #62
Conversation
|
@zaaack @tyronedougherty I'd prefer for that setting to be optional or maybe only enable that when debugging flags are set? I'm afraid that this may cause a perf regression on larger projects as embedding sourcemaps often have significant impact on the file size |
|
@kmagiera You are right, I'll update this as soon as possible. |
zaaack
changed the title
|
@kmagiera @tyronedougherty Done. |
zaaack
force-pushed
the
patch-1
branch
2 times, most recently
from
bac4eed to
04d7eba
Compare
|
@zaaack sorry for holding this off again but I guess I wasn't clear enough the last time. So what I meant is that we should associate the I don't think allowing users to change source maps to false is something we want to do. Doing that would make it impossible to get a meaningful stack trace. Also I realised that in the "client process" code we override uncaught handler so that the sourcemaps can be fetched from the "host process". I think this would need to be adjusted for the case when sourcemaps are inlined. |
zaaack
changed the title
|
@kmagiera Updated. I think I get what you mean... Looks like node-source-map-support has a option to support inline source map. Hoping I didn't make mistake. https://github.com/evanw/node-source-map-support#options |
|
Why hasn't this been merged? :S |
* Set babel sourcemap option to inline when debug * Add missing `inspectBrk` to the `debug` list Co-authored-by: zaaack <[email protected]>
|
Closing in favor of #118 |
|
Released in |
For debug.