Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification after server restart #80

Closed

Conversation

christopher-francisco
Copy link

The notification is done with node-notifier.

The notification is done with `node-notifier`.
@ghost
Copy link

ghost commented Nov 3, 2018

Hello @chris-fa. Thanks for your PR.

It looks like a new addition instead of a feature that is necessary for the package. So could you disable the notifications by default and implement enabling them via CLI options?

I remember the Laravel Elixir also showed such a notification after building the code, which irritated me very much. That's why I think showing system notifications by default can be annoying for other developers 😄

Thanks!

STRML added a commit that referenced this pull request Jan 5, 2021
Also relates to #79 and #80 as this can easily be added
as a --before-restart action.
@STRML
Copy link
Collaborator

STRML commented Jan 5, 2021

This can be done now with --before-restart:

babel-watch --before-restart="echo 'restarted!' | terminal-notifier" app.js

@STRML STRML closed this Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants