Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce restartApp instead of handleChange #99

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Debounce restartApp instead of handleChange #99

merged 1 commit into from
Apr 29, 2019

Conversation

iiroj
Copy link
Contributor

@iiroj iiroj commented Apr 29, 2019

When handleChange is debounced, sometimes the cache deletion is missed. This Pull Request changes the behaviour slightly by only debouncing the restartApp inside handleChange.

This is an issue in our containerised (large) development environment, where this patch has been working successfully.

When handleChange is debounced, sometimes the cache deletion is missed
@STRML
Copy link
Collaborator

STRML commented Apr 29, 2019

Oh, great catch. Thanks!

@STRML STRML merged commit 5221397 into kmagiera:master Apr 29, 2019
@iiroj iiroj deleted the debounce-restart branch April 30, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants