#403: add a feature to download MatchOverview of Topcoder Marathon Match #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukatani
reviewed
Mar 30, 2019
onlinejudge/service/topcoder.py
Outdated
| submissions += [TopcoderLongContestProblemIndividualResultsFeedSubmission(number, score, language, time)] | ||
| testcases = [] # type: List[TopcoderLongContestProblemIndividualResultsFeedTestCase] | ||
| for testcase in list(root)[4]: | ||
| test_case_id = int(list(testcase)[0].text or '') |
There was a problem hiding this comment.
この(or '')ってなんでしょう？int('')だと例外発生します。
There was a problem hiding this comment.
mypy を黙らせるための処理です。例外はむしろ発生するのが適切です。
ちょっと上で次のようにコメントしてるのと同じものです。
選択肢はいくつかありますが、まず # type: ignore を付けると行全体が無効化されてしまうのでだめ、次に
x = list(testcase)[0]
if x is None:
raise RuntimeError
test_case_id = int(x)は長すぎてこれもだめ。
次のような関数を定義することもできますが、
def unwrap(s: Optional[str]) -> str:これを定義するのと次のようにコメントで示すのはあまり差がないと思ったのですが、そうではなかったですか？
|
きれいに解決できる方法を見付けたのでそうしました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #403
かなりそのままな形で実装しました。
crrdのような妙な名前は Topcoder 側のしている省略に合わせています。型名がすごく長いですが、短くするよりましだと思ったのでこうなってます。