Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the feature to use module=ViewStandings of Topcoder Marathon Match #407

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Update the feature to use module=ViewStandings of Topcoder Marathon Match #407

merged 1 commit into from
Mar 31, 2019

Conversation

kmyk
Copy link
Member

@kmyk kmyk commented Mar 30, 2019

#406 のついでです。

  • 型を変えたので互換性は壊れました
  • method名を変えたのはついでです。変えても問題ないタイミングで「毎回通信が発生しそうな」名前にしたかった
  • テストがないのは仕様です。コンテスト開催中しか動かないのでテストには mock を書くしかなくて面倒です。加えて、ユーザの性質 (MMに参加していて、順位表の解析という発想を持っていて、Pythonライブラリを利用できる) から、彼らからのバグ報告が来ることに頼ってしまってよいはずです

@kmyk kmyk added this to the v6.2.0 milestone Mar 30, 2019
@kmyk kmyk requested a review from fukatani March 30, 2019 23:53
fukatani
fukatani approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@fukatani fukatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fukatani fukatani merged commit 5dc392e into master Mar 31, 2019
@fukatani fukatani deleted the feature/topcoder-standings branch March 31, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fukatani fukatani fukatani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kmyk @fukatani