Add permission to update namespaces/finalizer to webhook cluster role #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(similar to knative/eventing#5501) This patch adds the permission to update `namespaces/finalizers`. Since knative/pkg#2098 added ownerRef refers to namespace for webhook, we need this permission. Without it, cluster which has a stricter RBAC rules gets the following error: ``` cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on ... ``` Signed-off-by: Pierangelo Di Pilato <[email protected]>
knative-prow-robot
added
approved
|
/lgtm
/approve
On Tue 15. Jun 2021 at 22:05, Pierangelo Di Pilato ***@***.***> wrote:
@pierDipi <https://github.com/pierDipi> requested your review on: #1000
<#1000> Add
permission to update namespaces/finalizer to webhook cluster role.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1000 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTR2NNORYSHXSTXD7RLTS6W67ANCNFSM46X5P44Q>
.
--
Sent from Gmail Mobile
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
slinkydeveloper
pushed a commit
to slinkydeveloper/eventing-kafka-broker
that referenced
this pull request
Jun 18, 2021
…knative-extensions#1000) (similar to knative/eventing#5501) This patch adds the permission to update `namespaces/finalizers`. Since knative/pkg#2098 added ownerRef refers to namespace for webhook, we need this permission. Without it, cluster which has a stricter RBAC rules gets the following error: ``` cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on ... ``` Signed-off-by: Pierangelo Di Pilato <[email protected]>
matzew
pushed a commit
to matzew/eventing-kafka-broker
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(similar to knative/eventing#5501)
This patch adds the permission to update
namespaces/finalizers.Since knative/pkg#2098 added ownerRef refers to namespace for webhook,
we need this permission. Without it, cluster which has a stricter RBAC
rules gets the following error:
Signed-off-by: Pierangelo Di Pilato [email protected]