Removes using callbacks in webhooks. Relies on genericCRD interface instead to receive the defaulting and validating calls.

[gab-satchi]

Changes

• 🗑️ Removes using callbacks in webhooks
• 🗑️ removes extra conversion between unstructured objects to the eventing v1 types
• 🐛 Fixes an issue where an invalid Trigger can be created if its Broker was missing.

🐛 Fixes an issue where an invalid Trigger can be created if its Broker was missing.

/kind cleanup

[gab-satchi]

Each of these test cases are covered in the test above. This was testing the wrapper ValidateBroker function which is now fully removed.

[codecov]

Codecov Report

Merging #1018 (c20f835) into main (7ef9702) will decrease coverage by 0.12%.
The diff coverage is 28.57%.

❗ Current head c20f835 differs from pull request most recent head b28c34d. Consider uploading reports for the commit b28c34d to get more accurate results

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
- Coverage   73.74%   73.61%   -0.13%     
==========================================
  Files          44       44              
  Lines        3302     3332      +30     
==========================================
+ Hits         2435     2453      +18     
- Misses        777      790      +13     
+ Partials       90       89       -1     

Impacted Files	Coverage Δ
pkg/apis/eventing/v1alpha1/rabbitmq_types.go	100.00% <ø> (ø)
pkg/apis/eventing/v1alpha1/rabbitmq_validation.go	68.18% <ø> (+19.79%)	⬆️
pkg/apis/eventing/v1alpha1/broker_validation.go	74.69% <8.33%> (-9.64%)	⬇️
pkg/apis/eventing/v1alpha1/trigger_validation.go	62.50% <39.13%> (-10.42%)	⬇️
pkg/reconciler/trigger/trigger.go	63.47% <0.00%> (-0.54%)	⬇️
pkg/rabbit/queue.go	100.00% <0.00%> (ø)
pkg/rabbit/exchange.go	100.00% <0.00%> (ø)
pkg/reconciler/broker/resources/ingress.go	97.94% <0.00%> (+0.04%)	⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gabo1208]

Let me know when this is ready @gab-satchi

[gab-satchi]

It's ready @gabo1208

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment