Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] removing parse url from the get rabbitmqUrl function #1259

Conversation

knative-prow-robot
Copy link

This is an automated cherry-pick of #1239

Now Brokers and Sources accept broader rabbitmq url usernames and passwords characters to connect to RabbitMQ instances

… have special characters needed i.e when pulled from an active directory and the url does not fail to parse
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1259 (25ca3db) into release-1.11 (76794c0) will not change coverage.
The diff coverage is 53.84%.

@@              Coverage Diff              @@
##           release-1.11    #1259   +/-   ##
=============================================
  Coverage         74.69%   74.69%           
=============================================
  Files                44       44           
  Lines              3434     3434           
=============================================
  Hits               2565     2565           
  Misses              767      767           
  Partials            102      102           
Files Coverage Δ
pkg/rabbit/exchange.go 100.00% <ø> (ø)
pkg/reconciler/broker/broker.go 86.12% <100.00%> (ø)
pkg/rabbit/service.go 29.25% <50.00%> (ø)

@knative-prow
Copy link

knative-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2023
@Cali0707
Copy link
Member

/override codecov/patch

@knative-prow
Copy link

knative-prow bot commented Oct 19, 2023

@Cali0707: Overrode contexts on behalf of Cali0707: codecov/patch

In response to this:

/override codecov/patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 5b654fb into knative-extensions:release-1.11 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants