-
Notifications
You must be signed in to change notification settings - Fork 159
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imjasonh: 0 warnings.
In response to this:
Fixes #541
Proposed Changes
- Resync our custom resources every 10 hours, and rely on build/pod watch updates to trigger syncs in most cases
Resyncing every 30s seems to lead us to hit rate limits that we never recover from when there are too many builds in the system at a given time. Serving also switched to resyncing every 10h for similar scaling reasons.
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
(End time is not populated for any of the builds created in the load test, likely another bug) |
/test pull-knative-build-integration-tests |
1 similar comment
/test pull-knative-build-integration-tests |
@imjasonh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We ran into this at ~200 builds. Happy to test a fix. |
Fixes #541
Proposed Changes
Resyncing every 30s seems to lead us to hit rate limits that we never recover from when there are too many builds in the system at a given time. Serving also switched to resyncing every 10h for similar scaling reasons.
Release Note