add changelog entry

knative · Jun 22, 2020 · 2410198 · 2410198
1 parent e820ac9
commit 2410198
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -18,6 +18,10 @@
 |===
 | | Description | PR
 
+| 🐛
+| Fix Panic for `kn source apiserver` and `kn source binding` describe with Sink URI
+| https://github.com/knative/client/pull/901[#901]
+
 | 🐛
 | Fix Panic for `kn trigger describe` with Sink URI
 | https://github.com/knative/client/pull/900[#900]

diff --git a/pkg/kn/commands/source/binding/describe.go b/pkg/kn/commands/source/binding/describe.go
@@ -95,10 +95,10 @@ func writeSink(dw printers.PrefixWriter, namespace string, sink *duckv1.Destinat
 	subWriter := dw.WriteAttribute("Sink", "")
 	ref := sink.Ref
 	if ref != nil {
+		subWriter.WriteAttribute("Name", sink.Ref.Name)
 		if sink.Ref.Namespace != "" && sink.Ref.Namespace != namespace {
 			subWriter.WriteAttribute("Namespace", sink.Ref.Namespace)
 		}
-		subWriter.WriteAttribute("Name", sink.Ref.Name)
 		subWriter.WriteAttribute("Resource", fmt.Sprintf("%s (%s)", sink.Ref.Kind, sink.Ref.APIVersion))
 	}
 	uri := sink.URI