Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help message for kn service apply --env is appropriate #1449

Closed
rhuss opened this issue Sep 8, 2021 · 2 comments · Fixed by #1516
Closed

Help message for kn service apply --env is appropriate #1449

rhuss opened this issue Sep 8, 2021 · 2 comments · Fixed by #1516
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@rhuss
Copy link
Contributor

rhuss commented Sep 8, 2021

Bug report

kn service apply --help yields:

-e, --env stringArray                   Environment variable to set. NAME=value; you may provide this flag any number of times to set multiple environment variables. To unset, specify the environment variable name followed by a "-" (e.g., NAME-).

This is not correct since you can't add or remove env vars with apply but just set the full set of env variables.

Same possibly for --labels and --annotations (or any map-based option)

Expected behavior

The help message for --env should be different for kn service update and kn service apply as the behaviour is different (update : incremental changes by adding/removing, apply: full state)

The same is true for kn service create where removing env vars also doesn't make any sense.

Thanks to @pmbanugo for reporting this issue.

@rhuss rhuss added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2021
@boaz0
Copy link
Contributor

boaz0 commented Nov 1, 2021

@rhuss can you assign this to me after I finish with issue 1232

@rhuss
Copy link
Contributor Author

rhuss commented Nov 4, 2021

/assign boaz0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants