Fix env, annotation and labels flags in service create/update/apply

[boaz0]

Description/Changes

Update descriptions to the following flags in service create/update/apply:

• env
• labels
• annotations

If you can not unset the label/annotation/env then don't mention it in the description of the flag.

Reference

Fixes #1449

[knative-prow-robot]

@boaz0: 2 warnings.

In response to this:

Description/Changes

Update descriptions to the following flags in service create/update/apply:

• env
• labels
• annotations

If you can not unset the label/annotation/env then don't mention it in the description of the flag.

Reference

Fixes #1449

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Hi @boaz0. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1516 (4edf592) into main (4316d03) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1516      +/-   ##
==========================================
+ Coverage   79.39%   79.47%   +0.07%     
==========================================
  Files         162      162              
  Lines        8497     8530      +33     
==========================================
+ Hits         6746     6779      +33     
  Misses       1073     1073              
  Partials      678      678              

Impacted Files	Coverage Δ
pkg/kn/commands/container/add.go	94.87% <100.00%> (+0.13%)	⬆️
...kg/kn/commands/service/configuration_edit_flags.go	83.53% <100.00%> (+0.83%)	⬆️
pkg/kn/commands/source/container/create.go	90.24% <100.00%> (+0.24%)	⬆️
pkg/kn/commands/source/container/update.go	90.69% <100.00%> (+0.22%)	⬆️
pkg/kn/flags/podspec.go	79.25% <100.00%> (+2.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4316d03...4edf592. Read the comment docs.

[dsimansk]

/ok-to-test

[dsimansk]

It looks good to me, but it'd great if you could add unit tests to newly added AddCreateFlags to meet test coverage threshold as well.

[boaz0]

@dsimansk sure. No problem.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/container/add.go	96.0%	96.2%	0.2
pkg/kn/commands/service/configuration_edit_flags.go	89.4%	89.9%	0.5
pkg/kn/commands/source/container/create.go	93.5%	93.8%	0.2
pkg/kn/commands/source/container/update.go	94.1%	94.3%	0.2
pkg/kn/flags/podspec.go	84.4%	85.6%	1.2

[dsimansk]

Thanks @boaz0!

/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: boaz0, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment