Remove deprecated flags before 1.0 release

[dsimansk]

There're a few place flags/code comments that we mention xyz is depracated. Per discussion during WG call, let's clean in up a bit before 1.0 release next week.

➜  pkg git:(main) grep -irn "deprecated" .
./dynamic/lib_test.go:51:	// with deprecated CRD field spec version
./kn/commands/wait_flags_test.go:35:func TestAddWaitForReadyDeprecatedFlags(t *testing.T) {
./kn/commands/service/create_mock_test.go:448:func TestServiceCreateWithDeprecatedResourcesError(t *testing.T) {
./kn/commands/service/configuration_edit_flags.go:246:			return fmt.Errorf("only one of (DEPRECATED) --limits-cpu / --limits-memory and --limit can be specified")
./kn/commands/service/configuration_edit_flags.go:248:		fmt.Fprintf(cmd.OutOrStdout(), "\nWARNING: flags --limits-cpu / --limits-memory are deprecated and going to be removed in future release, please use --limit instead.\n\n")
./kn/commands/service/configuration_edit_flags.go:253:			return fmt.Errorf("only one of (DEPRECATED) --requests-cpu / --requests-memory and --request can be specified")
./kn/commands/service/configuration_edit_flags.go:255:		fmt.Fprintf(cmd.OutOrStdout(), "\nWARNING: flags --requests-cpu / --requests-memory are deprecated and going to be removed in future release, please use --request instead.\n\n")
./kn/commands/service/configuration_edit_flags.go:258:	// Deprecated "min-scale" in 0.19, updated to "scale-min"
./kn/commands/service/configuration_edit_flags.go:266:	// Deprecated "max-scale" in 0.19, updated to "scale-max"
./kn/config/types.go:74:	deprecatedKeyPluginsLookupInPath = "plugins.path-lookup"
./kn/config/types.go:79:// legacy config keys, deprecated
./kn/config/config.go:74:	if viper.IsSet(deprecatedKeyPluginsLookupInPath) {
./kn/config/config.go:75:		return viper.GetBool(deprecatedKeyPluginsLookupInPath)
./kn/config/config.go:117:	err = viper.BindPFlag(deprecatedKeyPluginsLookupInPath, bootstrapFlagSet.Lookup(flagPluginsLookupInPath))
./kn/config/config.go:140:	// viper.SetDefault(deprecatedKeyPluginsLookupInPath, bootstrapDefaults.lookupPluginsInPath)
./kn/config/config.go:198:	// Check the deprecated path first and fallback to it, add warning to error message
./kn/config/config.go:201:		fmt.Fprintf(os.Stderr, "WARNING: deprecated kn config directory '%s' detected. Please move your configuration to '%s'\n", configHome, migrationPath)
./kn/config/config.go:217:		// Check the deprecated path first and fallback to it, add warning to error message
./kn/config/config.go:220:			fmt.Fprintf(os.Stderr, "WARNING: deprecated kn config directory '%s' detected. Please move your configuration to '%s'\n", configHome, migrationPath)

• Flags

  • --limits-cpu
  • --limits-cpu
  • --request-memory
  • --request-cpu
  • --min-scale
  • --max-scale

• Old config & plugin location handling

  • handling of old path
  • warning message

• plugins.path-lookup might be good candidate to remove as well

  • config property

/cc @navidshaikh

[dsimansk]

/kind cleanup

[vyasgun]

/assign