Removing deprecated flags

[vyasgun]

Description

Removing the deprecated flags from kn command.

Changes

Removed the following flags:

• min-scale
• max-scale
• limits-cpu
• limits-memory
• requests-cpu
• requests-memory
• plugins.path-lookup

Reference

Fixes #1491

[knative-prow-robot]

@vyasgun: 0 warnings.

In response to this:

Description

Removing the deprecated flags from kn command.

Changes

Removed the following flags:

• min-scale
• max-scale
• limits-cpu
• limits-memory
• requests-cpu
• requests-memory
• plugins.path-lookup

Reference

Fixes #1491

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1498 (18e263f) into main (62b1f73) will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
+ Coverage   79.05%   79.40%   +0.35%     
==========================================
  Files         162      162              
  Lines        8454     8499      +45     
==========================================
+ Hits         6683     6749      +66     
+ Misses       1085     1070      -15     
+ Partials      686      680       -6     

Impacted Files	Coverage Δ
...kg/kn/commands/service/configuration_edit_flags.go	82.70% <ø> (+4.78%)	⬆️
pkg/kn/commands/source/ping/update.go	84.00% <0.00%> (-0.62%)	⬇️
pkg/errors/errors.go	100.00% <0.00%> (ø)
pkg/kn/plugin/stat.go	60.00% <0.00%> (ø)
pkg/serving/v1/client.go	82.77% <0.00%> (ø)
pkg/eventing/v1/client.go	87.67% <0.00%> (ø)
pkg/kn/traffic/compute.go	100.00% <0.00%> (ø)
pkg/serving/v1alpha1/client.go	86.76% <0.00%> (ø)
pkg/kn/commands/domain/update.go	65.71% <0.00%> (ø)
pkg/kn/commands/trigger/update.go	77.19% <0.00%> (ø)
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b1f73...18e263f. Read the comment docs.

[dsimansk]

With removal of the flag --lookup-plugins, the related e2e tests using the flag need to removed as well.

[dsimansk]

@vyasgun maybe lets keep the --lookup-plugins out of this PR. The flag is already hidden in help messages. We can check with @rhuss if he agrees to remove it completely.

The other flag should be safe to remove.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/configuration_edit_flags.go	87.3%	89.4%	2.1

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment