Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for setting containerConcurency #151

Closed
duglin opened this issue May 30, 2019 · 0 comments · Fixed by #157
Closed

add support for setting containerConcurency #151

duglin opened this issue May 30, 2019 · 0 comments · Fixed by #157

Comments

@duglin
Copy link
Contributor

duglin commented May 30, 2019

It would be nice to be able to set the containerConcurrency field via kn:

apiVersion: serving.knative.dev/v1alpha1
kind: Service
metadata:
  name: helloworld
spec:
  runLatest:
    configuration:
      revisionTemplate:
        spec:
          container:
            image: ${APP_IMAGE}
          containerConcurrency: 1

See last line.

Something like --max-concurrency=1
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 2, 2019
@rhuss
feature(service create/update): Add support of minScale/maxScale/target
efb23b7 
Autoscaler annotations are added to the revision template if
--min-scale / --max-scale / --target are provided to `kn service create`
or `kn service update`

Fixes knative#151
@rhuss rhuss mentioned this issue Jun 2, 2019
Merged
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 3, 2019
@rhuss
feature(service create/update): Add support of minScale/maxScale/target
dc32350 
Autoscaler annotations are added to the revision template if
--min-scale / --max-scale / --target are provided to `kn service create`
or `kn service update`

Fixes knative#151
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 6, 2019
@rhuss
feature(service create/update): Add support of minScale/maxScale/target
d7359ec 
Autoscaler annotations are added to the revision template if
--min-scale / --max-scale / --target are provided to `kn service create`
or `kn service update`

Fixes knative#151
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 6, 2019
@rhuss
feat(service create/update): Add support of minScale/maxScale/target
27d167d 
Autoscaler concurrencty annotations are added to the revision template if
--min-scale / --max-scale / --concurrency-target are provided to `kn service create`
and `kn service update`

Fixes knative#151
rhuss added a commit to rhuss/knative-client that referenced this issue Jun 7, 2019
@rhuss
feat(service create/update): Add support of minScale/maxScale/concurr…
143f363 
…ency-target/concurrency-limit

Autoscaler concurrency annotations are added to the revision template if
--min-scale / --max-scale / --concurrency-target/--concurrency-limit
are provided to `kn service create` and `kn service update`

Fixes knative#151
knative-prow-robot pushed a commit that referenced this issue Jun 8, 2019
@rhuss @knative-prow-robot
feat(service create/update): Add support of minScale/maxScale/concurr…
b885e41 
…ency-target/concurrency-limit (#157)

Autoscaler concurrency annotations are added to the revision template if
--min-scale / --max-scale / --concurrency-target/--concurrency-limit
are provided to `kn service create` and `kn service update`

Fixes #151
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Fix SSH keys workaround for kubetest (knative#151)
2039a3c 
Create the `~/.ssh` dir if it doesn't exist, don't assume it always exist.

Bonus: fail fast also during cluster setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(service create/update): Add support of minScale/maxScale/target rhuss/knative-client
1 participant
@duglin