Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kn plugins integration test #308

Closed
maximilien opened this issue Jul 26, 2019 · 6 comments · Fixed by #591
Closed

Kn plugins integration test #308

maximilien opened this issue Jul 26, 2019 · 6 comments · Fixed by #591
Assignees
@maximilien
Labels
kind/feature New feature or request

Comments

@maximilien
Copy link
Contributor

In what area(s)?

Kn plugins

Classifications:

/kind feature

Describe the feature:

Now that #249 is merged we need to have a separate integration test (IT) for that feature. There is a lot to test. As a start, let's add this:

  1. simple plugin execution of a BASH and executable plugin in
    a. --plugins-dir
    b. $PATH
  2. finding plugin in both --plugins-dir and $PATH
  3. verifying plugin overshadowing
  4. verifying plugin cannot override a core command

There will be more to add to these ITs as plugins matures and more features are added.
@maximilien maximilien added the kind/feature New feature or request label Jul 26, 2019
@maximilien
Copy link
Contributor Author

/assign @maximilien

maximilien added a commit to maximilien/client that referenced this issue Jul 26, 2019
@maximilien
feature(integration tests): adds Kn plugins IT (fixes knative#308)
147fedb
maximilien added a commit to maximilien/client that referenced this issue Jul 30, 2019
@maximilien
feature(integration tests): adds Kn plugins IT (fixes knative#308)
aad4412
maximilien added a commit to maximilien/client that referenced this issue Jul 30, 2019
@maximilien
Adds intergration tests for Kn plugins
e2a3fa3 
Finishes knative#308
@maximilien
Copy link
Contributor Author

I’ll push this once #313 is merged since I need to change some of the output tests.

@navidshaikh
Copy link
Collaborator

@maximilien +1

@maximilien
Copy link
Contributor Author

Need some integration tests. Latest issues found in #411 showed this is needed. Making this my top priority with #414 and then #320

/cc @rhuss

maximilien added a commit to maximilien/client that referenced this issue Oct 3, 2019
@maximilien
[WIP] (fixes knative#308): adds e2e tests for plugins
efebed2
@maximilien
Copy link
Contributor Author

maximilien commented Nov 1, 2019 •
edited
Loading

Finally, getting back to this after our long unforeseen delays on Knative... Fixed one issue #468 which was blocking my WIP on this.

@maximilien maximilien mentioned this issue Nov 5, 2019
Merged
@maximilien
Copy link
Contributor Author

Now that #468 is merged (yeah). Getting back to this to submit it soon. Finally.

@maximilien maximilien mentioned this issue Dec 23, 2019
Merged
navidshaikh added a commit to navidshaikh/client that referenced this issue Mar 23, 2020
@navidshaikh
CI was here (knative#308)
a778290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximilien maximilien

Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes(#308): adds e2e tests for plugins maximilien/client
2 participants
@maximilien @navidshaikh