Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce --debug and --verbose as global options #333

Open
Tracked by #1587
rhuss opened this issue Aug 6, 2019 · 10 comments
Open
Tracked by #1587

Introduce --debug and --verbose as global options #333

rhuss opened this issue Aug 6, 2019 · 10 comments
Assignees
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@rhuss
Copy link
Contributor

rhuss commented Aug 6, 2019

In what area(s)?

Describe the feature:

Debugging and verbose output should be treated in a consistent way over all commands. Currently, we have

As there are supposed to be more such output modifying flags coming in over time, I suggest to use --debug and --verbose with categories to fine tune this:

  • Adding --debug for very low-level information. Only useful for developer of kn itself
  • Adding a --verbose option for increasing the detail level of the information presented. Examples are
    • kn service describe --verbose to add more details to a service (like the image digests, or all env vars/annotations/labels)
    • kn plugin list --verbose to also print the plugin directories where plugins are looked up
    • kn service create --debug to print also the HTTP headers

In order to tune debug and verbose output, I'd suggest to introduce categories:

  • --debug --> all debug info
  • --debug=all --> all debug info
  • --debug=http --> only http related debugging
  • --verbose --> all verbose output
  • --verbose=config --> config related information, too
  • --verbose=config,details --> config information and details (made up here to show how to combine categories)

This suggestion would introduce exactly two options, --debug and --verbose (with the possible values shown in the help page). The alternative would be to have an extra option for every category like in --log-http, but this would blow up the help pages and UX surface considerably over time.

@rhuss
Copy link
Contributor Author

rhuss commented Sep 10, 2019

Should be tackled together with #182 IMO

coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
bazel is currently only used to parse test results, and doesn't build anything, thus all its settings are unnecessary (it works fine without them for our use case).
@rhuss rhuss self-assigned this Jun 8, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2020
@rhuss
Copy link
Contributor Author

rhuss commented Nov 10, 2020

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2020
@github-actions
Copy link

github-actions bot commented Feb 9, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2021
@dsimansk
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 14, 2021
@rhuss
Copy link
Contributor Author

rhuss commented Jun 1, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 1, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 31, 2021
@rhuss rhuss added the triage/accepted Issues which should be fixed (post-triage) label Sep 1, 2021
@rhuss
Copy link
Contributor Author

rhuss commented Sep 1, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2021
@rhuss rhuss moved this from Backlog to Selected in Client Planning Nov 16, 2021
@rhuss rhuss moved this to Backlog in Client Planning Nov 16, 2021
@rhuss rhuss moved this from Selected to Backlog in Client Planning Nov 16, 2021
@dsimansk dsimansk moved this from Backlog to Selected in Client Planning Nov 16, 2021
@rhuss
Copy link
Contributor Author

rhuss commented Nov 17, 2021

Related to this issue

@rhuss rhuss moved this to Todo in Client 1.2 (0.28) Jan 5, 2022
@rhuss rhuss mentioned this issue Jan 27, 2022
4 tasks
@dsimansk dsimansk added this to the Knative 1.10 milestone Mar 23, 2023
@dsimansk dsimansk modified the milestones: Knative 1.10 , Knative 1.12 Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: In Design
Status: Todo
Development

No branches or pull requests

3 participants