Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E test for "kn source binding" commands #631

Closed
rhuss opened this issue Feb 1, 2020 · 2 comments · Fixed by #634
Closed

Add E2E test for "kn source binding" commands #631

rhuss opened this issue Feb 1, 2020 · 2 comments · Fixed by #634
Assignees
@MIBc
Labels
area/e2e good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request
Milestone
v0.13.0

Comments

@rhuss
Copy link
Contributor

rhuss commented Feb 1, 2020 •
edited
Loading

In what area(s)?

E2E Testing

Describe the feature:

We need some E2E tests for the CRUD commands of kn source binding
@rhuss rhuss added the kind/feature New feature or request label Feb 1, 2020
@knative-prow-robot knative-prow-robot added the good first issue Denotes an issue ready for a new contributor. label Feb 1, 2020
@MIBc
Copy link
Contributor

MIBc commented Feb 1, 2020

I'm interested in the issue. I can have a try.

@rhuss
Copy link
Contributor Author

rhuss commented Feb 1, 2020

cool, I will assign it to you

/assign MIBc

MIBc added a commit to MIBc/client that referenced this issue Feb 4, 2020
@MIBc
Add E2E test for "kn source binding" commands
422e34a 
Fixes knative#631
* Add E2E test for "kn source binding" commands.
* Fix typo.
MIBc added a commit to MIBc/client that referenced this issue Feb 4, 2020
@MIBc
Add E2E test for "kn source binding" commands
1ffa16d 
Fixes knative#631

* Add E2E test for "kn source binding" commands.
* Fix typo.
@MIBc MIBc mentioned this issue Feb 4, 2020
Merged
MIBc added a commit to MIBc/client that referenced this issue Feb 4, 2020
@MIBc
Add E2E test for "kn source binding" commands
dae4cfb 
Fixes knative#631

* Add E2E test for "kn source binding" commands.
* Fix typo.
@rhuss rhuss added the area/e2e label Feb 5, 2020
MIBc added a commit to MIBc/client that referenced this issue Feb 7, 2020
@MIBc
Add E2E test for "kn source binding" commands
cedf310 
Fixes knative#631

* Add E2E test for "kn source binding" commands.
* Fix typo.
knative-prow-robot pushed a commit that referenced this issue Feb 7, 2020
@MIBc
Add E2E test for "kn source binding" commands (#634)
16bbfa3 
Fixes #631

* Add E2E test for "kn source binding" commands.
* Fix typo.
@navidshaikh navidshaikh added this to the v0.13.0 milestone Mar 9, 2020
dsimansk pushed a commit to dsimansk/client that referenced this issue Mar 25, 2021
@markusthoemmes
Pull in main from upstream (knative#631)
86e413d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MIBc MIBc

Labels
area/e2e good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

Add E2E test for "kn source binding" commands MIBc/client
4 participants
@rhuss @navidshaikh @MIBc @knative-prow-robot