Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honour deletionTimestamp for "kn revision delete", too #815

Closed
rhuss opened this issue Apr 21, 2020 · 5 comments · Fixed by #860
Closed

Honour deletionTimestamp for "kn revision delete", too #815

rhuss opened this issue Apr 21, 2020 · 5 comments · Fixed by #860
Assignees
@MIBc
Labels
kind/feature New feature or request
Milestone
v0.15.0

Comments

@rhuss
Copy link
Contributor

rhuss commented Apr 21, 2020

As followup to #805 add the deletion timestamp handling also for kn revision delete.
@rhuss rhuss added the kind/feature New feature or request label Apr 21, 2020
@MIBc
Copy link
Contributor

MIBc commented Apr 21, 2020

I want to continue working on it.

@rhuss
Copy link
Contributor Author

rhuss commented Apr 21, 2020

/assign MIBc

@rhuss
Copy link
Contributor Author

rhuss commented Apr 21, 2020

Yes, sorry for already merging the other PR but we are cutting a release today (0.14.0), so wanted to have your contribution to be included.

@MIBc
Copy link
Contributor

MIBc commented Apr 29, 2020

Why we need to check deletionTimestamp for revision delete?
Unlike update command. Deleting revision will not hang until timeout. It may raise resource not found error if revision has been deleted.

@rhuss
Copy link
Contributor Author

rhuss commented Apr 29, 2020

Not sure if I understand you comment correcly. Wouldn't it make sense to have consistent behaviour for deleting any resource ? I.e. if the thedeletionTimestamp is set then no deletion is attempt again (regardless of what we delete).

MIBc added a commit to MIBc/client that referenced this issue May 27, 2020
@MIBc
Check deletionTimestamp for "kn revision delete"
4829c5e 
Fixes: knative#815
@MIBc MIBc mentioned this issue May 27, 2020
Merged
@navidshaikh navidshaikh added this to the v0.15.0 milestone May 27, 2020
knative-prow-robot pushed a commit that referenced this issue Jun 1, 2020
@MIBc @navidshaikh
Check deletionTimestamp for "kn revision delete" (#860)
bcf2ec3 
* Check deletionTimestamp for "kn revision delete"

Fixes: #815

* Update error message for revision delete

Co-authored-by: Navid Shaikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MIBc MIBc

Labels
kind/feature New feature or request
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

Check deletionTimestamp for "kn revision delete" MIBc/client
3 participants
@rhuss @navidshaikh @MIBc