Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channel create example with inbuilt alias for imcv1beta1 #1005

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Fix channel create example with inbuilt alias for imcv1beta1 #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/cmd/kn_channel_create.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ kn channel create NAME
# Create a channel 'pipe' with default setting for channel configuration
kn channel create pipe
# Create a channel 'imc1' of type InMemoryChannel using inbuilt alias 'imc'
kn channel create imc1 --type imc
# Create a channel 'imc1' of type InMemoryChannel using inbuilt alias 'imcv1beta1'
kn channel create imc1 --type imcv1beta1
# same as above without using inbuilt alias but providing explicit GVK
Comment on lines +20 to 22
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in line with whats mentioned on line no 22

kn channel create imc1 --type messaging.knative.dev:v1beta1:InMemoryChannel
Expand Down
4 changes: 2 additions & 2 deletions pkg/kn/commands/channel/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ func NewChannelCreateCommand(p *commands.KnParams) *cobra.Command {
# Create a channel 'pipe' with default setting for channel configuration
kn channel create pipe
# Create a channel 'imc1' of type InMemoryChannel using inbuilt alias 'imc'
kn channel create imc1 --type imc
# Create a channel 'imc1' of type InMemoryChannel using inbuilt alias 'imcv1beta1'
kn channel create imc1 --type imcv1beta1
# same as above without using inbuilt alias but providing explicit GVK
kn channel create imc1 --type messaging.knative.dev:v1beta1:InMemoryChannel
Expand Down