Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for test flake when sync waiting and an intermediate error occurs #1052

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Fix for test flake when sync waiting and an intermediate error occurs #1052

merged 2 commits into from
Oct 8, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Oct 7, 2020 •
edited
Loading

This fix workaround the issue as described in knative/serving#9727 but is useful in general to cancel an error window if a non-error condition event is received.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 7, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2020
mattmoor
mattmoor reviewed Oct 7, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

@rhuss
Copy link
Contributor Author

rhuss commented Oct 7, 2020

/test pull-knative-client-integration-tests

@rhuss rhuss mentioned this pull request Oct 7, 2020
Open
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2020
@rhuss
Copy link
Contributor Author

rhuss commented Oct 7, 2020

/test pull-knative-client-integration-tests

1 similar comment
@rhuss
Copy link
Contributor Author

rhuss commented Oct 7, 2020

/test pull-knative-client-integration-tests

maximilien
maximilien approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/retest

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 7, 2020
@rhuss
Copy link
Contributor Author

rhuss commented Oct 8, 2020

/test pull-knative-client-integration-tests

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2020
@rhuss rhuss changed the title Test PR to analyze flake [DO NOT MERGE] Fix for test flake when sync waiting and an intermediate error occurs Oct 8, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/wait/wait_for_ready.go 77.9% 76.8% -1.1

@dsimansk
Copy link
Contributor

dsimansk commented Oct 8, 2020

Thanks @rhuss for the thorough analysis and fix. IMO it looks good, but lets wait for other reviewers.

/approve

navidshaikh
navidshaikh approved these changes Oct 8, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maximilien, navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 878b037 into knative:master Oct 8, 2020
navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Oct 9, 2020
@rhuss @navidshaikh
Fix for test flake when sync waiting and an intermediate error occurs (…
6a7267e 
…knative#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added
@navidshaikh navidshaikh mentioned this pull request Oct 12, 2020
Merged
navidshaikh pushed a commit to navidshaikh/client that referenced this pull request Oct 12, 2020
@rhuss @navidshaikh
Fix for test flake when sync waiting and an intermediate error occurs (…
4ab02c3 
…knative#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added
@navidshaikh navidshaikh mentioned this pull request Oct 12, 2020
Merged
@navidshaikh navidshaikh added the backport/candidate Consider this PR to be backported to the release branch label Oct 12, 2020
knative-prow-robot pushed a commit that referenced this pull request Oct 12, 2020
@navidshaikh @rhuss @zroubalik
[release-0.17] Backport #1052 and #1054 (#1058)
2d1944d 
* Fix for test flake when sync waiting and an intermediate error occurs (#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added

* Add WithLabel list filter to serving client lib (#1054)

* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <[email protected]>

* adding tests

Signed-off-by: Zbynek Roubalik <[email protected]>

* update changelog

Signed-off-by: Zbynek Roubalik <[email protected]>

* Update CHANGELOG

Co-authored-by: Roland Huß <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
knative-prow-robot pushed a commit that referenced this pull request Oct 12, 2020
@navidshaikh @rhuss @zroubalik
[release-0.18] Backport #1052 and #1054 (#1059)
b6fdb5c 
* Fix for test flake when sync waiting and an intermediate error occurs (#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added

* Add WithLabel list filter to serving client lib (#1054)

* add WithLabel list filter

Signed-off-by: Zbynek Roubalik <[email protected]>

* adding tests

Signed-off-by: Zbynek Roubalik <[email protected]>

* update changelog

Signed-off-by: Zbynek Roubalik <[email protected]>

* Update CHANGELOG

Co-authored-by: Roland Huß <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
@navidshaikh navidshaikh added backported-to/0.17 and removed backport/candidate Consider this PR to be backported to the release branch labels Oct 12, 2020
rhuss added a commit to rhuss/knative-client that referenced this pull request Oct 12, 2020
@rhuss
Fix for test flake when sync waiting and an intermediate error occurs (…
c918e2a 
…knative#1052)

* fix: Cancel error timer on sync wait when a non-error event arrives

* chore: Added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@navidshaikh navidshaikh navidshaikh approved these changes

@maximilien maximilien maximilien approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rhuss @knative-metrics-robot @dsimansk @knative-prow-robot @maximilien @mattmoor @navidshaikh