Fix service/revision list output with '-o' param

[evidolob]

Description

This PR fixes behaviour of service list -o <format> and revision list -o <format> command in case when there are no services/revisions:

$ ./kn service list -o json
{
    "apiVersion": "serving.knative.dev/v1",
    "items": [],
    "kind": "ServiceList"
}

Changes

• revision/list.go now checks -o option before type No revisions found.
• service/list.go now checks -o option before type No services found.

Reference

Fixes #1273

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[knative-prow-robot]

@evidolob: 0 warnings.

In response to this:

Description

This PR fixes behaviour of service list -o <format> and revision list -o <format> command in case when there are no services/revisions:

$ ./kn service list -o json
{
   "apiVersion": "serving.knative.dev/v1",
   "items": [],
   "kind": "ServiceList"
}

Changes

• revision/list.go now checks -o option before type No revisions found.
• service/list.go now checks -o option before type No services found.

Reference

Fixes #1273

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Welcome @evidolob! It looks like this is your first PR to knative/client 🎉

[knative-prow-robot]

Hi @evidolob. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dsimansk]

Thanks!
/ok-to-test

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[dsimansk]

This fix covers service list and revision list, but there's a few more list subcommands that has exactly the same handling of empty lists.

@rhuss @navidshaikh should we tackle it at once? Or creating another issue would be sufficient?

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[maximilien]

/ok-to-test
/approve

Thanks for the contribution

[maximilien]

@evidolob you might need to sign the CLA... see @google-cla bot message above

[evidolob]

@googlebot I signed it!

[evidolob]

@dsimansk I can handle all list commands in this PR

[dsimansk]

@dsimansk I can handle all list commands in this PR

If you don't mind the extra work, please go ahead. IMO it'd be better to align the listing output for every command.

[evidolob]

/retest

[rhuss]

/retest

[rhuss]

/retest

[rhuss]

The tests are currently failing, so we can't include this PR for 0.22. However as this is a fix, we can quickly release a 0.22.1 afterwards when the e2e test issue is fixed.

[rhuss]

/hold

[evidolob]

/retest

[evidolob]

/retest

[evidolob]

/retest

[evidolob]

/retest

[evidolob]

/retest

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/channel/list_types.go	81.1%	81.0%	-0.1
pkg/kn/commands/source/list.go	70.3%	73.2%	2.9
pkg/kn/commands/source/list_types.go	75.7%	76.2%	0.5

[evidolob]

/retest

[dsimansk]

@evidolob thanks!

I've gone through the PR and it covers all list commands. Except the newly added domain by me, I'll fix that in a follow-up PR.

/approve
/lgtm
/unhold

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk,maximilien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment